Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL: CustomizableDateOption or CustomizableDateValue should indicate the precise Date option type #31075

Closed
1 of 5 tasks
laurentiumagureanu opened this issue Nov 27, 2020 · 4 comments · Fixed by #31164
Closed
1 of 5 tasks
Assignees
Labels
Component: GraphQL GraphQL Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.1 Indicates original Magento version for the Issue report.
Milestone

Comments

@laurentiumagureanu
Copy link

Preconditions (*)

  1. Magento 2.4.1 CE

Steps to reproduce (*)

  1. Add multiple Date customizable options to a product. Use different date types: Date, Date & Time, Time
  2. Query the previous product via graphQL and display the customizable options. Use sample query below:
{
  products(filter: {sku: {eq: "test-sku"}}) {
    items {
      sku
      __typename
      id
      name
      ... on SimpleProduct {
         options {
          __typename
          option_id
          required
          sort_order
          title
          ... on CustomizableDateOption {
            value {
              uid
              price
              price_type
              __typename
            }
            __typename
          }
        }
      }
    }
  }
}

Expected result (*)

  1. The customizable option part of the response, for Date options, should contain information about the precise field type ( Date, Date & Time, Time)

Actual result (*)

  1. There is no way to tell which is which. All Date options use the same type for the value field
    image

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Nov 27, 2020

Hi @laurentiumagureanu. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 27, 2020
@engcom-Delta engcom-Delta added Reported on 2.4.1 Indicates original Magento version for the Issue report. Component: GraphQL GraphQL labels Nov 30, 2020
@mauragcyrus
Copy link

@magento export issue to Jira project MCLOUD as Story

@magento-engcom-team
Copy link
Contributor

✅ Jira issue (https://jira.corp.magento.com/browse/MCLOUD-7343) is successfully created for this issue.

@magento-engcom-team magento-engcom-team added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Dec 2, 2020
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Dec 2, 2020
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Dec 2, 2020
@m2-community-project m2-community-project bot added this to Ready for Development in GraphQL Backlog Dec 2, 2020
@m2-community-project m2-community-project bot removed this from Ready for Development in High Priority Backlog Dec 2, 2020
@korovitskyi
Copy link
Collaborator

@magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: GraphQL GraphQL Issue: ready for confirmation Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.1 Indicates original Magento version for the Issue report.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

7 participants