-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: APIsComponent: GraphQLGraphQLGraphQLFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P1Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Progress: doneProject: GraphQLReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
Fix all nullable customizable_options
customizable_options: <SelectedCustomizableOption]
to be non nullable
customizable_options: [SelectedCustomizableOption]!
this will fix the BiC introduced in 2.4.1
will also fix the bundle problem which is the only one that's nullable now
[~cspruiell> plz update this description accordingly
!screenshot-1.png|thumbnail!
- I need to query a user's cart via
graphQL
and includecustomizable_options
for each cart item. - In order to do that now I need to use a fragment for each type implementing
CartItemInterface
- Problem is that
BundleCartItem
hascustomizable*options: [SelectedCustomizableOption]!
( not nullable ) while all the other cart item types havecustomizable*options: [SelectedCustomizableOption]
(nullable)
Expected result (*)
- The
customizable_options
field should be part ofCartItemInterface
since all implementing types include it. - The
customizable_options
field should at least use the same type declaration in all implementing types in order to be able to fetch it in thecart
query.
Actual result (*)
Metadata
Metadata
Assignees
Labels
Area: APIsComponent: GraphQLGraphQLGraphQLFixed in 2.4.xThe issue has been fixed in 2.4-develop branchThe issue has been fixed in 2.4-develop branchIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P1Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing.Progress: doneProject: GraphQLReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Type
Projects
Status
Done