Expecting 404, getting 500: "Trying to access array offset on value of type bool"

[erfanimani]

Preconditions (*)

1. Magento 2.4.1
2. PHP 7.4

Steps to reproduce (*)

1. As an admin, create an saleable product with any URL, such as "box"
2. Set "Generate "category/product" URL Rewrites" to "No"
3. As a customer, visit the URL /abc/box.html

Expected result (*)

1. 404 page not found error, as the category abc does not exist

Actual result (*)

1. 500, Trying to access array offset on value of type bool on vendor/magento/module-catalog-url-rewrite/Model/Storage/DynamicStorage.php on line 182

PHP 7.4 is become stricter than PHP 7.3 with regards to these types of errors and that's why this bug is showing up it's head now.

https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/CatalogUrlRewrite/Model/Storage/DynamicStorage.php#L182

The way the code is written doesn't make sense: the false check is done after an array access is attempted; the false check should be done first.

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @erfanimani. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[erfanimani]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @erfanimani. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @erfanimani, here is your Magento Instance: https://f8c82a5df22c8449f5750aaa3633c1dd-2-4-develop.instances.magento-community.engineering
Admin access: https://f8c82a5df22c8449f5750aaa3633c1dd-2-4-develop.instances.magento-community.engineering/admin_ddef
Login: 539546ad
Password: 169e9f461bc1

[erfanimani]

@magento give me 2.4-develop instance with env php 7.4

[magento-deployment-service]

Hi @erfanimani. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @erfanimani, here is your Magento Instance: https://f8c82a5df22c8449f5750aaa3633c1dd-2-4-develop.instances.magento-community.engineering
Admin access: https://f8c82a5df22c8449f5750aaa3633c1dd-2-4-develop.instances.magento-community.engineering/admin_73d4
Login: 0e40c360
Password: 5013a9f37720

[erfanimani]

@magento give me 2.4-develop instance with env php 7.4

[magento-deployment-service]

Hi @erfanimani. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @erfanimani, here is your Magento Instance: https://f8c82a5df22c8449f5750aaa3633c1dd-2-4-develop.instances.magento-community.engineering
Admin access: https://f8c82a5df22c8449f5750aaa3633c1dd-2-4-develop.instances.magento-community.engineering/admin_c25d
Login: 13f51a3e
Password: 59cc31fca2df

[erfanimani]

I can't reproduce through the deployment service. I'm unsure of whether it's actually giving me a php 7.4 instance.

I can reproduce on 2.4-develop and 2.4.2 contributor package on my local.