Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API add to cart with simple product but different options increases qty instead of adding new cart item #32302

Closed
1 of 5 tasks
DavidLambauer opened this issue Feb 26, 2021 · 24 comments
Assignees
Labels
Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.2 Indicates original Magento version for the Issue report.

Comments

@DavidLambauer
Copy link
Contributor

DavidLambauer commented Feb 26, 2021

We're trying to add the same simple product into the cart, but with custom options through the api. The expected result would be to have 2 items in the cart with different custom options. Actual result is the first item is in cart with qty of 2.

Preconditions

Magento Version 2.4.2

Steps to reproduce

You might want to check the video attached below

Capto_Capture.2021-02-26_01-44-29_PM.mp4

.

  1. Create a cart via rest call: POST | {{ base_url }}guest-carts
  2. Receive the cart to make sure no items are in the cart: GET | {{ base_url }}guest-carts/cartId
  3. Add a simple product with custom options to the cart: POST | {{ base_url }}guest-carts/cartId/items

Example Payload:

{
  "cartItem": {
    "sku": "THE-SKU-OF-YOUR-SIMPLE-PRODUCT",
    "qty": 1,
    "product_option": {
      "extension_attributes": {
        "custom_options": [
          {
            "option_id": "1",
            "option_value": "abc"
          },
          {
            "option_id": "2",
            "option_value": "abc"
          }
        ]
      }
    },
    "quoteId": "YOUR-QUOTE-ID"
  }
}
  1. (optional) Re-do step 2 to validate that the product was added to the cart.
  2. Re-do step 3 but change the custom option values in the payload.
  3. Re-do step 2 to again to see that two different products got merged into one but the qty was increased.

Expected result (*)

Actual result (*)

The cart should contain two items, each one with the custom options that were selected.


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Feb 26, 2021

Hi @DavidLambauer. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@simonmaass
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @simonmaass. Thank you for your request. I'm working on Magento instance for you.

@simonmaass
Copy link

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Mar 2, 2021

Hi @simonmaass! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@simonmaass
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Mar 2, 2021

Hi @simonmaass! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

@simonmaass
Copy link

@magento I am working on this

@simonmaass simonmaass removed their assignment Mar 2, 2021
@simonmaass
Copy link

can confirm issue

@stale
Copy link

stale bot commented May 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 14 days if no further activity occurs. Is this issue still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? Thank you for your contributions!

@stale stale bot added the stale issue label May 18, 2021
@simonmaass
Copy link

this is not fixed and should not be stale!

@stale stale bot removed the stale issue label May 18, 2021
@engcom-Alfa engcom-Alfa self-assigned this May 27, 2021
@m2-assistant
Copy link

m2-assistant bot commented May 27, 2021

Hi @engcom-Alfa. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Alfa engcom-Alfa added Reported on 2.4.2 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels May 27, 2021
@engcom-Alfa
Copy link
Contributor

Hi , Tried on Magento 2.4 Develop , issue is replicable , Hence request to look into it.

@engcom-Alfa engcom-Alfa added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 27, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board May 27, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Alfa
Thank you for verifying the issue. Based on the provided information internal tickets MC-42474 were created

Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board May 27, 2021
@m2-community-project m2-community-project bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label May 27, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jun 2, 2021

Hi @gabrieldagama. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Jun 2, 2021
@gabrieldagama gabrieldagama removed their assignment Jun 2, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Ready for Development in High Priority Backlog Jun 2, 2021
@engcom-Hotel engcom-Hotel self-assigned this Jul 13, 2021
@m2-assistant
Copy link

m2-assistant bot commented Jul 13, 2021

Hi @engcom-Hotel. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Jul 13, 2021
@engcom-Hotel engcom-Hotel removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch labels Jul 13, 2021
@engcom-Hotel
Copy link
Contributor

Hi @DavidLambauer,

We have tried to reproduce this issue in 2.4-develop branch, but this is not reproducible. May be this issue has been fixed in this branch.

So we request you to please try to reproduce this in 2.4-develop branch and let us know, if you are able to reproduce this issue in this branch.

Thanks

@engcom-Hotel engcom-Hotel added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response labels Jul 13, 2021
@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog Jul 15, 2021
@DavidLambauer
Copy link
Contributor Author

Well, maybe we wait two more weeks if the next person confirms the issue again? A couple of people mentioned that this is still valid and has not been fixed yet. I can't provide even more information. I think the description and how you reproduce this issue is pretty clear.

@emanuelcorrea
Copy link

@magento I am working on this

@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2021

Hi @emanuelcorrea! 👋
Thank you for collaboration. Only members of Community Contributors Team are allowed to be assigned to the issue. Please use @magento add to contributors team command to join Contributors team.

@emanuelcorrea
Copy link

@magento add to contributors team

@m2-assistant
Copy link

m2-assistant bot commented Jul 27, 2021

Hi @emanuelcorrea! 👋
Thank you for joining. Please accept team invitation 👉 here 👈 and add your comment one more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Api Use with concrete module component label E.g. "Component: Api" + "Catalog" Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Issue: needs update Additional information is require, waiting for response Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.2 Indicates original Magento version for the Issue report.
Projects
Development

No branches or pull requests

8 participants