Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Update README.md of Google_Analytics module #32616

Closed
4 tasks
m2-assistant bot opened this issue Mar 29, 2021 · 2 comments · Fixed by #32448
Closed
4 tasks

[Issue] Update README.md of Google_Analytics module #32616

m2-assistant bot opened this issue Mar 29, 2021 · 2 comments · Fixed by #32448
Assignees
@charles-tychons
Labels
Component: GoogleOptimizer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Mar 29, 2021

This issue is automatically created based on existing pull request: #32448: Update README.md of Google_Analytics module

Description (*)

Update Readme content for Google Analytics module, Google Analytics settings is not under General tab, it is located under Sales tab.

Fixed Issues (if relevant)

  1. magento/devdocs README content for modules - work in M2 Code devdocs#4451: README content for modules - work in M2 Code

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: GoogleOptimizer Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Mar 29, 2021
@m2-assistant m2-assistant bot mentioned this issue Mar 29, 2021
Merged
5 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Mar 29, 2021
@engcom-Oscar engcom-Oscar added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 29, 2021
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @engcom-Oscar
Thank you for verifying the issue. Based on the provided information internal tickets MC-41622 were created

Issue Available: @engcom-Oscar, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@gabrieldagama
Copy link
Contributor

Hi @m2-assistant[bot]. Thank you for your report.
The issue has been fixed in #32448 by @charles-tychons in 2.4-develop branch
Related commit(s):

The fix will be available with the upcoming 2.4.3 release.

@gabrieldagama gabrieldagama added the Fixed in 2.4.x The issue has been fixed in 2.4-develop branch label Apr 11, 2021
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charles-tychons charles-tychons

Labels
Component: GoogleOptimizer Fixed in 2.4.x The issue has been fixed in 2.4-develop branch Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update README.md of Google_Analytics module charles-tychons/magento2
4 participants
@gabrieldagama @magento-engcom-team @charles-tychons @engcom-Oscar