Urlresolver does not resolve path "/" correctly when multiple homepages has the same identifier

[capkafitz]

Preconditions (*)

1. Magento 2.4.0

Steps to reproduce (*)

1. Create for multiple stores a cms page with the same identifier (in this case 'home').
2. Go to Configuration > General > Web > Default Pages
3. Set for each store the newly created page as homepage, example in the database:
   
4. Execute graphQl query urlresolver:
   
5. Result for default store (stored in database without delimiter):
   
6. Result for store where homepage value is stored in database with delimiter:
   

---

Expected result (*)

1. Result for store where homepage value is stored in database with delimiter should have a correct url resolver response:
   

Actual result (*)

1. Actual result equals null
   

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @capkafitz. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[capkafitz]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @capkafitz. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @capkafitz, here is your Magento Instance: https://5b7a96b7e688b72f59cd9ee86081eb1b-2-4-develop.instances.magento-community.engineering
Admin access: https://5b7a96b7e688b72f59cd9ee86081eb1b-2-4-develop.instances.magento-community.engineering/admin_d821
Login: c5e3e648
Password: 9c102bced6db

[capkafitz]

I can confirm it is reproducible on the 2.4-develop instance:

1. Two stores views:
   

2. 2 pages with the same identifier, each page for one store view:
   

3. Set each page as homepage in the configuration:
   
   

4. Urlresolver request via graphQl:
   Correct response for default store (default):
   

Null response for second store (default_2):

[capkafitz]

Fixed issue in our project with following patch:

--- a/vendor/magento/module-cms-url-rewrite-graph-ql/Model/Resolver/UrlRewrite/HomePageUrlLocator.php	2020-07-20 13:13:08.000000000 +0200
+++ b/vendor/magento/module-cms-url-rewrite-graph-ql/Model/Resolver/UrlRewrite/HomePageUrlLocator.php	2021-07-28 14:00:37.830555850 +0200
@@ -40,6 +40,10 @@
                 Page::XML_PATH_HOME_PAGE,
                 ScopeInterface::SCOPE_STORE
             );
+            $homePageDelimiterPosition = strrpos($homePageUrl, '|');
+            if ($homePageDelimiterPosition) {
+                $homePageUrl = substr($homePageUrl, 0, $homePageDelimiterPosition);
+            }
             return $homePageUrl;
         }
         return null;

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento2.4-develop branch and the issue is reproducible:
Steps to reproduce:

1. Magento - 2 Store views (Ref Guide)
2. Create CMS page for default store (Admin - Content - Pages - Add New Page - Pages in Websites - Select Default Store View) and Save
3. Create CMS page for new Store using same above url-key (Admin - Content - Pages - Add New Page - Pages in Websites - Select your new Store View) and Save.
4. Clear Cache
5. Go to Configuration > General > Web (Change Scope of the website to "Default Store View") > Default Pages > CMS Home Page -> Select newly created page for default Store and Save
6. Go to Configuration > General > Web (Change Scope of the website to "New Store view") > Default Pages > CMS Home Page -> Select newly created page for new Store and Save
7. Execute graphQl query urlresolver for default store: - No issue
8. Execute graphQL query Urlresolver for new store - Issue
   Issue: Correct response for default store (default) but getting Null response for second store

Default Store:

Note: This issue is also reproducible for default Store with below Steps:

1. When CMS page is created 1st for new store and set the same url-key for Default Store CMS page
2. Go to Configuration > General > Web (Change Scope of the website to "New Store view") > Default Pages > CMS Home Page -> Select newly created page for new Store and Save
3. Go to Configuration > General > Web (Change Scope of the website to "Default Store view") > Default Pages > CMS Home Page -> Select newly created page for default Store and Save
4. Execute graphQl query urlresolver for france(new Store) store: - No issue
5. Execute graphQL query Urlresolver for default store - Issue
   Issue: Null response for default store. Correct response for new store