New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urlresolver does not resolve path "/" correctly when multiple homepages has the same identifier #33615
Comments
Hi @capkafitz. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
@magento give me 2.4-develop instance |
Hi @capkafitz. Thank you for your request. I'm working on Magento instance for you. |
Hi @capkafitz, here is your Magento Instance: https://5b7a96b7e688b72f59cd9ee86081eb1b-2-4-develop.instances.magento-community.engineering |
Fixed issue in our project with following patch: --- a/vendor/magento/module-cms-url-rewrite-graph-ql/Model/Resolver/UrlRewrite/HomePageUrlLocator.php 2020-07-20 13:13:08.000000000 +0200
+++ b/vendor/magento/module-cms-url-rewrite-graph-ql/Model/Resolver/UrlRewrite/HomePageUrlLocator.php 2021-07-28 14:00:37.830555850 +0200
@@ -40,6 +40,10 @@
Page::XML_PATH_HOME_PAGE,
ScopeInterface::SCOPE_STORE
);
+ $homePageDelimiterPosition = strrpos($homePageUrl, '|');
+ if ($homePageDelimiterPosition) {
+ $homePageUrl = substr($homePageUrl, 0, $homePageDelimiterPosition);
+ }
return $homePageUrl;
}
return null; |
Hi @engcom-November. Thank you for working on this issue.
|
Verified the issue on Magento2.4-develop branch and the issue is reproducible:
Note: This issue is also reproducible for default Store with below Steps:
|
✅ Confirmed by @engcom-November Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself. |
@magento I am working on this |
@magento add to contributors team |
Hi @mariusboia! 👋 |
@magento I'm working on it |
@magento I'm working on it |
Hi @capkafitz , Kindly upgrade to the latest 2.4-develop to retest the case. For any Magento related references, you may refer to the Magento user guide. Thanks! |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
The text was updated successfully, but these errors were encountered: