GraphQL - price_range for configurable products is affected by disabled variants

[aligent-lturner]

Preconditions (*)

1. Magento 2.4.x (reproduced on latest dev at time of writing)

Steps to reproduce (*)

1. Create a configurable product with a sku "test-config-1" with a single configurable attribute (e.g. size) and at least 2 options (e.g. S, M, L)
2. Set the price of one variant to be $40, and the others to be $50
3. Disable the variant with the lower price
4. Execute the following query:

query {
  products(
    filter: {
      sku: {
        eq: "test-config-1"
      }
    }
  ) {
    items {
      sku
      price_range {
        minimum_price {
          discount {
            amount_off
            percent_off
          }
          final_price {
            value
            currency
          }
          regular_price {
            value
            currency
          }
        }
      }
      ...on ConfigurableProduct {
        configurable_options {
          values {
            label
          }
        }
        variants {
          attributes {
            label
          }
          product {
            sku
          }
        }
      }
    }
  }
}

Expected result (*)

1. price_range values are unaffected by disabled variants:

{
  "data": {
    "products": {
      "items": [
        {
          "sku": "test-config-1",
          "price_range": {
            "minimum_price": {
              "discount": {
                "amount_off": 0,
                "percent_off": 0
              },
              "final_price": {
                "value": 50,
                "currency": "USD"
              },
              "regular_price": {
                "value": 50,
                "currency": "USD"
              }
            }
          },
          "configurable_options": [
            {
              "values": [
                {
                  "label": "S"
                },
                {
                  "label": "M"
                },
                {
                  "label": "L"
                }
              ]
            }
          ],
          "variants": [
            {
              "attributes": [
                {
                  "label": "L"
                }
              ],
              "product": {
                "sku": "test-config-1-L"
              }
            },
            {
              "attributes": [
                {
                  "label": "M"
                }
              ],
              "product": {
                "sku": "test-config-1-M"
              }
            }
          ]
        }
      ]
    }
  }
}

Actual result (*)

1. Price of disabled sku affects price_range values of configurable:

{
  "data": {
    "products": {
      "items": [
        {
          "sku": "test-config-1",
          "price_range": {
            "minimum_price": {
              "discount": {
                "amount_off": 10,
                "percent_off": 20
              },
              "final_price": {
                "value": 40,
                "currency": "USD"
              },
              "regular_price": {
                "value": 50,
                "currency": "USD"
              }
            }
          },
          "configurable_options": [
            {
              "values": [
                {
                  "label": "S"
                },
                {
                  "label": "M"
                },
                {
                  "label": "L"
                }
              ]
            }
          ],
          "variants": [
            {
              "attributes": [
                {
                  "label": "L"
                }
              ],
              "product": {
                "sku": "test-config-1-L"
              }
            },
            {
              "attributes": [
                {
                  "label": "M"
                }
              ],
              "product": {
                "sku": "test-config-1-M"
              }
            }
          ]
        }
      ]
    }
  }
}

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

I consider this to be critical data, as incorrect pricing is provided to the customer. A work-around would be to change the price of the disabled product, but this is not a good solution.

Note - the variants field being returned does not show the disabled product, so I believe the solution would involve applying the same logic used by its collection to the collection used for calculating pricing.

[m2-assistant]

Hi @aligent-lturner. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[aligent-lturner]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @aligent-lturner. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @aligent-lturner, here is your Magento Instance: https://df93008fc68f711f59a9f7470627f23a-2-4-develop.instances.magento-community.engineering
Admin access: https://df93008fc68f711f59a9f7470627f23a-2-4-develop.instances.magento-community.engineering/admin_ae63
Login: 25dc4c04
Password: e30dec90a066

[aligent-lturner]

Confirmed on 2.4-develop:

Created configurable:

Run GraphQL query and see incorrect pricing:

[aligent-lturner]

Note - additional bug found.

If configuration is changed to show out of stock products, then disabled products also appear under variants field.
I believe this is due to disabled products essentially being "out of stock", and hence being filtered out by Magento\CatalogGraphQl\Model\Resolver\Products\DataProvider\Product\CollectionProcessor\StockProcessor

public function process(
    Collection $collection,
    SearchCriteriaInterface $searchCriteria,
    array $attributeNames,
    ContextInterface $context = null
): Collection {
    if (!$this->stockConfig->isShowOutOfStock()) {
        $this->stockStatusResource->addIsInStockFilterToCollection($collection);
    }

    return $collection;
}

[aligent-lturner]

I believe that potentially, a fix for the variants issue would be changing

magento2/app/code/Magento/CatalogGraphQl/Model/Resolver/Products/DataProvider/Product/CollectionProcessor/VisibilityStatusProcessor.php

Line 38 in 39e1300

$collection->joinAttribute('status', 'catalog_product/status', 'entity_id', null, 'inner');

to

$collection->addAttributeToFilter('status', Status::STATUS_ENABLED);

[m2-assistant]

Hi @shikhamis11. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[shikhamis11]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @shikhamis11. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @shikhamis11, here is your Magento Instance: https://df93008fc68f711f59a9f7470627f23a-2-4-develop.instances.magento-community.engineering
Admin access: https://df93008fc68f711f59a9f7470627f23a-2-4-develop.instances.magento-community.engineering/admin_1f29
Login: 3b9cb2e4
Password: f46e742d57ec