Magento 2.4.3 Customer has no any vault token save, but vault payment method appears in Admin checkout

[jignesh-coder]

Preconditions (*)

1. Magento 2.4.3

Steps to reproduce (*)

1. Go to Magento Admin panel
2. Setup Braintree payment method and enable vault payment (Stores - Configuration - Sales - Payment Methods - Configure Braintree - Enable Card Payments and Enable Vault for Card )
3. Reindex and Clear cache
4. Admin - Sales - Orders - Create new Order - Create New Customer / or select any existing customer
5. Add Products
   Payment Method section - Issue: "Stored Cards" Payment option is getting displayed
   In payment method section it show token payment
6. Select the option and submit Order: Issue: "Order saving error: Public hash should be defined" error message is displayed to the user.
   Note: There is no issue on Front-end - "Stored Cards" payment option is not displayed for signed in user in Checkout page

Expected result (*)

1. If customer has no token saved, than Vault Payment should not be shown in Payment section of Admin Order creation page

Actual result (*)

Order saving error: Public hash should be defined" error message is displayed to the user.

Even after saving the Card details - User cannot able to make payment from Admin using Stored Cards option

There is no issue on front-end - User is able to make payment using stored card and place Order - No issue

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @jignesh-coder. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

Please, add a comment to assign the issue: @magento I am working on this

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Verified the issue on Magento 2.4-develop branch and the issue is reproducible:
Steps to reproduce:
Stores - Configuration - Sales - Payment Methods - Configure Braintree - Enable Card Payments and Enable Vault for Card Payments - Yes and Save
Reindex and Clear cache
Admin - Sales - Orders - Create new Order - Create New Customer / or select any existing customer
Add Products
Payment Method section - Issue: "Stored Cards" Payment option is getting displayed
Select the option and submit Order: Issue: "Order saving error: Public hash should be defined" error message is displayed to the user.
Note: There is no issue on Front-end - "Stored Cards" payment option is not displayed for signed in user in Checkout page

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.magento.com/browse/AC-1119 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[SilinMykola]

@magento I am working on this

[yurii-denyshchenko]

Any update on this?

[jignesh-coder]

@yurii-denyshchenko I solved this error from my own way

Add code in di.xml

<type name="Magento\Quote\Model\Quote\Payment">
        <plugin name="payment-data" type="Vendor\Extension\Plugin\Payment" />
    </type>

in file Payment.php add code

namespace Vendor\Extension\Plugin;
class Payment
{
    public function beforeImportData(
        \Magento\Quote\Model\Quote\Payment $subject,
        $data
    ) {
        $vaultMethod = preg_replace('/^([a-z_]+vault)_\d+$/i', '$1', $data['method']);
        if (!is_null($vaultMethod) && $vaultMethod !== $data['method']) {
            $data['method'] = $vaultMethod;
        }
        return [$data];
    
}

[engcom-Alfa]

HI @jignesh-coder , @SilinMykola and @yurii-denyshchenko Thanks for your contribution here.
Internal team has picked up the ticket to fix with the internal ticket number AC-1119.
Thanks

[engcom-Hotel]

Hello @jignesh-coder,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-1119 by the internal team
Related commits: fd7e45e

Based on the Jira ticket, the target version is 2.4.6.

Thanks

[atIOCrON]

We had this issue on Magento ver. 2.4.5-p1 so we upgraded to Magento ver. 2.4.6-p2 and I can confirm it is now resolved.

Unfortunately, the same issue exists if you enable PayPal through Braintree and set Vault Enabled to yes. In this case, "Stored Accounts (PayPal)" will show as a payment method for admin orders even if there is no saved PayPal account.

I've added a new issue to solve it:

#38010