-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The problem with sprintf(Magento\Framwork\Phrase()) construction in PHP >= 8 #34085
Comments
Hi @andrewbess. Thank you for your report.
Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:
For more details, please, review the Magento Contributor Assistant documentation. Please, add a comment to assign the issue:
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @eduard13. Thank you for working on this issue.
|
@magento export issue to Jira project AC as Story |
Description (*)
We found a problem with
sprintf(__())
andsprintf(Magento\Framwork\Phrase())
construction in PHP >= 8.The error looks like "Expected parameter of type 'string', 'Magento\Framework\Phrase' provided".
This problem should be found and fixed in Magento codebase.
Currently, there are about 20 problems with provided constructions.
We need to change constructions to
sprintf(__()->render())
.The text was updated successfully, but these errors were encountered: