-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GraphQl] Cart error messages are faulty #34546
Comments
Hi @Hexmage. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. 🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-Hotel. Thank you for working on this issue.
|
Hello @Hexmage, Thanks for posting the issue! I would like to suggest you add for eg:
Will return:
You can see Thanks |
@engcom-Hotel It's nice that there are error messages in the cart response, but they need a second pass over. Because as they are now they aren't good enough. |
Hello @Hexmage, Thanks for the reply! This is the valid point, if the cart item is less in stock then proper handling is required. I have followed the below steps to reproduce the issue:
It should display which item has not enough quantity. Updating the main description as well. Thanks |
Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Once all required labels are present, please add |
✅ Jira issue https://jira.corp.magento.com/browse/AC-1965 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue. |
@Usik2203 I'd rather have something that has to be unique to identify the product, because the product name can be identical for products. Also your solution doesn't solve the null object that suddenly got added to the items array. |
Any update about null value? I can still reproduce this on 2.4.3-p2 |
@alitopaloglu |
Hi @Hexmage did you make any progress on this? I'm desperately looking for a solution. |
@PauloPhagula |
Hello, |
@Hexmage I just checked and magento2-pwa didnt fix the issue either |
@marwan-corals Personally I used a plugin on the function to add an error string element to each order_item with the raw exception message in there instead of the empty node. |
@Hexmage, thanks for the reply, but if the item is shown as null, how is this handled? |
@Hexmage are you willing to help here ? |
@marwan-corals
The schema.graphqls additions
|
They removed the module : magento/magento2-pwa@96c5f5f |
That explains a lot. |
Thanks, @Hexmage the provided code is helpful; one more note here is to add to di.xml
|
Hi @Hexmage , Thanks for your contribution and collaboration. I have tried to reproduce the issue in Followed below steps :
After running above query I am not getting any error message Please test it in latest Thanks |
@engcom-Lima |
HI @Hexmage , I have tried to reproduce the issue in 2.4-develop and followed below steps but issue is not reproducible to me:
Kindly provide me more information inorder to reproduce the isssue. Thanks |
Hi @Hexmage , Thank for your contribution and collaboration. Please provide more information required to reproduce the issue. Thanks |
Preconditions (*)
Steps to reproduce (*)
Expected result (*)
Actual result (*)
Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.
The text was updated successfully, but these errors were encountered: