Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Show customer_grid indexer as green when realtime #34648

Closed
3 of 5 tasks
m2-assistant bot opened this issue Nov 16, 2021 · 4 comments · Fixed by #34557
Closed
3 of 5 tasks

[Issue] Show customer_grid indexer as green when realtime #34648

m2-assistant bot opened this issue Nov 16, 2021 · 4 comments · Fixed by #34557
Assignees
Labels
Area: Performance Component: Indexer feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Nov 16, 2021

This issue is automatically created based on existing pull request: #34557: Show customer_grid indexer as green when realtime


Description

Magento recommends that all indexers be set in schedule mode ("Update by Schedule") except for customer_grid which should be in realtime mode ("Update on Save"). This is documented here in the devdocs and the Site-Wide Analysis Tool reports this also.

Screen-shot of Site-Wide Analysis Tool

Screenshot_2021-11-06_21-37-48


Currently Magento renders all indexers as 'green' when they are in schedule mode, including customer_grid. This is misleading as the customer_grid is not in the recommended state when set as schedule and shows in 'red' when in realtime mode which is its recommended state.

This pull request makes the colours match the recommended state for each indexer.

Related Pull Requests

None

Fixed Issues

None

Manual testing scenarios

  1. Set all indexers as realtime with: php bin/magento indexer:set-mode realtime
  2. Observe colours for each indexer in admin (System -> Tools -> Index Management)
  3. Set all indexers as schedule with: php bin/magento indexer:set-mode schedule
  4. Observe colours for each indexer in admin (System -> Tools -> Index Management)
  5. Set the customer_grid indexer as realtime with: php bin/magento indexer:set-mode realtime customer_grid
  6. Observe colours for each indexer in admin (System -> Tools -> Index Management)
Screen-shot of indexers all set 'Update on Save'

Screenshot_2021-11-06_21-48-58

Screen-shot of indexers all set 'Update by Schedule'

Screenshot_2021-11-06_21-50-32

Screen-shot of indexers set to their recommended modes

Screenshot_2021-11-06_21-45-49

Questions or comments

I have made the function which determines the preferred mode public to allow for extensibility with plugins.

Should the Design Config Grid indexer also be in this category of 'prefer realtime mode'?

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Nov 16, 2021
@engcom-Alfa engcom-Alfa added the Priority: P3 May be fixed according to the position in the backlog. label Nov 16, 2021
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Nov 16, 2021
@m2-community-project m2-community-project bot removed this from Ready for Confirmation in Issue Confirmation and Triage Board Nov 16, 2021
@engcom-November engcom-November self-assigned this Nov 30, 2022
@m2-assistant
Copy link
Author

m2-assistant bot commented Nov 30, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hi @fredden ,
Thank you for reporting and collaboration. Verified the behavior on Magento 2.4-develop instance and is reproducible. But however this is existing behavior of Magento as per Magento Docs screenshot. Existing behavior: Mode: "Update on Save" will be marked in Red and "Update by Schedule" in green for any indexers. Any indexer that requires re-index(including customer grid), status will be changed to "Reindex required" in red color regardless of the mode set. But as per Magento devdocs "Update by Schedule" does not support the customer_grid indexer. Agreed that this change would bring better user experience and hence we considering this as feature request.
Thank you.

@m2-community-project m2-community-project bot added this to Pull Request in Progress in Feature Requests Backlog Nov 30, 2022
@m2-community-project m2-community-project bot removed this from Pull Request In Progress in Low Priority Backlog Nov 30, 2022
@engcom-November engcom-November removed their assignment Nov 30, 2022
@engcom-Lima engcom-Lima added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Performance labels Jul 31, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-9223 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Jul 31, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@github-jira-sync-bot github-jira-sync-bot added the Progress: PR Created Indicates that Pull Request has been created to fix issue label Aug 21, 2023
@m2-community-project m2-community-project bot moved this from Pull Request in Progress to Done in Feature Requests Backlog Aug 31, 2023
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue Progress: PR in progress labels Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Performance Component: Indexer feature request Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: ready for confirmation Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

5 participants