Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Captcha refreshes when Payment Method is changed (when checkout Captcha is set to OFF) #34855

Closed
1 task
pmonosolo opened this issue Dec 20, 2021 · 23 comments
Closed
1 task
Labels
Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@pmonosolo
Copy link

Preconditions (*)

  1. ReCaptcha turned OFF on all of the forms:

image

  1. ReCaptcha keys added to the configuration

image

  1. At least 2 payment methods are enabled.

Steps to reproduce (*)

  1. Go to checkout page
  2. Click on different payment methods and notice request to /captcha/refresh/ is being made when payment method is changed.

Expected result (*)

  1. No request to refresh ReCaptcha when ReCaptcha is turned off for Checkout.

Actual result (*)

  1. Request is made to refresh to ReCaptcha which creates a delay of about 0.5 - 1.5 seconds on checkout page while totals are reloading.

image


Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
@m2-assistant
Copy link

m2-assistant bot commented Dec 20, 2021

Hi @pmonosolo. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@pmonosolo
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @pmonosolo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @pmonosolo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-November engcom-November self-assigned this Dec 21, 2021
@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2021

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@pmonosolo
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @pmonosolo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @pmonosolo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label Dec 30, 2021
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Dec 30, 2021
@pmonosolo
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @pmonosolo. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @pmonosolo, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@engcom-November
Copy link
Contributor

Hi @pmonosolo ,
Verified the issue on Magento 2.4-develop branch but cannot able to reproduce the issue with provided steps. Kindly verify the issue on Magento 2.4-develop branch and provide missing steps if any if the issue is still reproducible.
Thank you.

@engcom-November engcom-November added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Jan 31, 2022
@pmonosolo
Copy link
Author

pmonosolo commented Feb 1, 2022

Hi @pmonosolo , Verified the issue on Magento 2.4-develop branch but cannot able to reproduce the issue with provided steps. Kindly verify the issue on Magento 2.4-develop branch and provide missing steps if any if the issue is still reproducible. Thank you.

Hello, I got access to demo instance today.

Here are the tests:

image

image

^^ you can see here /refresh is being called.

The checkout ReCaptcha is turned off:

image

The instance from another ticket can be used to test this:

Admin access: https://fec85852d553821a047c03511225dba0.instances.magento-community.engineering/admin_f8b5
Login: 65d69133
Password: 5a0f52cfb398

It looks like the actual recaptcha is not being triggered, its the original Magento captcha that is being refreshed:
{"imgSrc":"https://fec85852d553821a047c03511225dba0.instances.magento-community.engineering/media/captcha/base/d63305d3d16607e2d1efc96b50b81081.png"}
{"imgSrc":"https://fec85852d553821a047c03511225dba0.instances.magento-community.engineering/media/captcha/base/b1f30744e2565ac6ef6780041e9a53fc.png"}
{"imgSrc":"https://fec85852d553821a047c03511225dba0.instances.magento-community.engineering/media/captcha/base/1e3ca4fb3f120139f704d92b2ae13f21.png"}

Each of these requests are 0.5 seconds:

image

Here is the look of the page:

image

I checked Customer Configuration and original Magento captcha is turned on:

image

Although the Checkout / Placing Order is not turned on:

image

So maybe it should not be generating Captcha when you click on each payment method when it's turned off in Configuration?

@pmonosolo
Copy link
Author

pmonosolo commented Feb 1, 2022

I did an additional test and turned off Admin and Customer Captcha:

ADMIN
image

CUSTOMER
image

I'm getting the same result, /refresh is being called:
image

@pmonosolo pmonosolo changed the title ReCaptcha refreshes when Payment Method is changed (when checkout ReCaptcha is set to OFF) Captcha refreshes when Payment Method is changed (when checkout Captcha is set to OFF) Feb 2, 2022
@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2022

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@m2-community-project m2-community-project bot removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Feb 8, 2022
@engcom-Hotel
Copy link
Contributor

Hello @pmonosolo,

We have tried to reproduce the issue in Magento 2.4-develop branch and the issue is reproducible for us. For us too the ReCaptcha is disabled for the below pages:

image

We have enabled the ReCaptcha V2:
image

And on the checkout page that refresh is hitting:
1

Hence confirming this issue.

Thanks

@engcom-Hotel engcom-Hotel added Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Framework labels Feb 8, 2022
@engcom-Hotel engcom-Hotel added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 8, 2022
@m2-community-project m2-community-project bot moved this from Needs Update to Confirmed in Issue Confirmation and Triage Board Feb 8, 2022
@m2-community-project m2-community-project bot removed the Issue: needs update Additional information is require, waiting for response label Feb 8, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2338 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Feb 8, 2022

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Feb 8, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Feb 8, 2022
@pmonosolo
Copy link
Author

Hello @pmonosolo,

We have tried to reproduce the issue in Magento 2.4-develop branch and the issue is reproducible for us. For us too the ReCaptcha is disabled for the below pages:

image

We have enabled the ReCaptcha V2: image

And on the checkout page that refresh is hitting: 1

Hence confirming this issue.

Thanks

Sorry my original post was about ReCaptcha, but I later found out, its the original Magento captcha that is being refreshed.

If you look at response result for /refresh its an image of captcha letters:

image

image

@pmonosolo
Copy link
Author

pmonosolo commented Oct 5, 2022

Any update on this issue guys? @engcom-Hotel

I mean seriously this is like 500ms of dead space while your customer is fighting against their thoughts of "Do I really need this?"

When used on One Step Checkouts it's even slower because the sections reload multiple times.

@engcom-Hotel
Copy link
Contributor

engcom-Hotel commented Oct 6, 2022

Hello @pmonosolo,

We have started working on this issue. We will update you further on this.

Thanks

@engcom-Hotel engcom-Hotel added Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. and removed Priority: P3 May be fixed according to the position in the backlog. labels Oct 6, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in High Priority Backlog Oct 6, 2022
@m2-community-project m2-community-project bot removed this from Ready for Development in Low Priority Backlog Oct 6, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Oct 17, 2022
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Oct 19, 2022
@engcom-Hotel
Copy link
Contributor

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-2338 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-2338&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in High Priority Backlog Nov 15, 2022
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 15, 2022
@pmonosolo
Copy link
Author

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-2338 by the internal team Related commits: https://github.com/magento/magento2/search?q=AC-2338&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

Beautiful! Thank you! @engcom-Hotel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

4 participants