Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue] Make the title of the "Show Password" checkbox translatable #34857

Closed
5 tasks
m2-assistant bot opened this issue Dec 21, 2021 · 3 comments · Fixed by #34370
Closed
5 tasks

[Issue] Make the title of the "Show Password" checkbox translatable #34857

m2-assistant bot opened this issue Dec 21, 2021 · 3 comments · Fixed by #34370
Assignees
@densen45
Labels
Area: Account area: localization Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2021

This issue is automatically created based on existing pull request: #34370: Make the title of the "Show Password" checkbox translatable

Description (*)

The title of the "Show Password" checkbox (Customer Login, Customer Registration, Customer Edit (Change Password section), Customer Set New Password) is not translatable. This pull request makes the title translatable.

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

  1. Create an i18n translation for the string "Show Password".
  2. Access the above mentioned pages.
  3. Hover over the checkbox to see the title.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: Customer Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Dec 21, 2021
@m2-assistant m2-assistant bot mentioned this issue Dec 21, 2021
Merged
6 tasks
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Dec 21, 2021
@engcom-Alfa engcom-Alfa added Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch area: localization Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 21, 2021
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Dec 21, 2021
@engcom-Alfa engcom-Alfa added Area: Account Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Dec 21, 2021
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2019 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Dec 21, 2021

✅ Confirmed by @engcom-Alfa. Thank you for verifying the issue.
Issue Available: @engcom-Alfa, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@densen45 densen45

Labels
Area: Account area: localization Component: Customer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
High Priority Backlog
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the title of the "Show Password" checkbox translatable densen45/magento2
3 participants
@densen45 @engcom-Alfa @github-jira-sync-bot