Customer who exceeded max login failures not able to login even after reset password

[MagicLegend]

Preconditions (*)

1. Magento 2.4.0 CE

Steps to reproduce (*)

1. Lock yourself out of a customer account
2. Reset the password
3. Lock is still active

Expected result (*)

1. Lock yourself out of a customer account
2. Reset the password
3. Lock is removed

Actual result (*)

1. Lock yourself out of a customer account
2. Reset the password
3. Lock is still active
4. The User account will active after sometime

This was fixed before in #15255. However, this commit removed this one-line fix again: cdc0fd3#diff-b8e39c5ed5e0b80ed62825ba186962adf41803236c50285ab7466ec65f632967L627

What is the reason for removing this fix?

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @MagicLegend. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Hotel, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[engcom-Hotel]

Hello @MagicLegend,

Thanks for posting this issue!

We have tried to reproduce the issue in Magento 2.4-develop branch and it is not reproducible for us, we have followed all the steps mentioned in the main description.

The account has been unlocked after some time, please ensure that the cron has been installed for that instance. Let us know if we have missed anything.

Thanks

[MagicLegend]

@engcom-Hotel

But that is not the issue. The issue is that it doesn't immediately unlock the account after a password reset. This caused confusion for our customers, and I personally agree that it is odd behaviour that I can't see a security-improvement for. I see that this used to be the case before M2.4, so I am wondering why this was changed.

Thank you for your time.

[engcom-Hotel]

Hello @MagicLegend,

I agree with your point that the user is not unlocked immediately. Hence confirming the issue and edit the main description accordingly:

After exceeded max login failures(Frontend):

After exceeded max login failures(Backend):

After resetting the password (Frontend), still unable to log in:

In the admin panel, the user status is still locked.

Thanks