Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not you?" link not shown in header with persistence enabled in 2.4.3-p1 #35182

Closed
2 of 10 tasks
dphilipps opened this issue Mar 11, 2022 · 10 comments
Closed
2 of 10 tasks
Assignees
Labels
Area: Cart & Checkout Component: Persistent Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@dphilipps
Copy link

dphilipps commented Mar 11, 2022

Preconditions (*)

  1. Magento 2.4.3-p1 or dev-develop
  2. Customers->Persistent Shopping Cart->Enable Persistence must be set to YES and all other options below set to YES
  3. When logging into front end the checkbox "Remember Me What's this?" must be ticked

Steps to reproduce (*)

  1. Set Customers->Persistent Shopping Cart->Enable Persistence to YES and all other options below set to YES
  2. Set General->Web->Default Cookie Settings->Cookie Lifetime to 60 seconds (this is only useful to speed up the testing time but the issue still exists with the default cookie lifetime
  3. Sign in to Luma store with Demo Customer Access (roni_cost@example.com) WITH checkbox "Remember Me What's this?" ticked
  4. Browse to any product and add to cart (this step can be omitted but it is useful to prove the persistence is enabled and working when the cart is retrieved)
  5. Wait for cookie lifetime to expire simulating a customer's session timing out
  6. Browse to homepage and refresh

Expected result (*)

  1. With a persistent cookie is applied, a Not Veronica Costello? link should appears in the page header, to give the customer the ability to terminate the persistent session and start working as a guest, or log in as a different customer.
  2. See Magento documentation for documented behaviour: https://docs.magento.com/user-guide/sales/cart-persistent-workflow.html

Actual result (*)

  1. The "Not you" link is not displayed on the header
  2. The first link is "Sign in"
  3. To prove persistence is enabled and working, browse to a product and add to cart
  4. Previous cart is restored showing both products that have been added
  5. See screenshot of actual behaviour
    image

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

May cause a customer to unwittingly purchase items added to a previous user on a shared computer as per the example in the documentation.

Actual result (*)

  1. The "Not you" link is not displayed on the header
  2. The first link is "Sign in"
  3. To prove persistence is enabled and working, browse to a product and add to cart
  4. Previous cart is restored showing both products that have been added
  5. The "Not you" link is STILL not displayed on the header even after retrieving the cart

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

May cause a customer to unwittingly purchase items added to a previous user on a shared computer as per the example in the documentation.

@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2022

Hi @dphilipps. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@dphilipps
Copy link
Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @dphilipps. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-November engcom-November self-assigned this Mar 11, 2022
@m2-assistant
Copy link

m2-assistant bot commented Mar 11, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link

Verified the issue on Magento 2.4-develop branch and the issue is reproducible.
"Not You" link is not getting displayed in header section as per magento documentation
Hence confirming the issue

@engcom-November engcom-November added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Component: Persistent Area: Cart & Checkout Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Mar 14, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Mar 14, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2622 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Mar 14, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Mar 28, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Mar 28, 2022
@Usik2203
Copy link
Contributor

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Dev In Progress in High Priority Backlog May 13, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog May 16, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog May 16, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Done in High Priority Backlog May 17, 2022
@engcom-Bravo
Copy link
Contributor

Hello @dphilipps,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-2619 by the internal team

Related commits:https://github.com/magento/magento2/search?q=AC-2619&type=commits

Based on the Jira ticket, the target version is 2.4.5.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Cart & Checkout Component: Persistent Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

6 participants