Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product customizable options incorrect after "import options" #35200

Closed
1 of 5 tasks
anvanza opened this issue Mar 16, 2022 · 20 comments
Closed
1 of 5 tasks

Product customizable options incorrect after "import options" #35200

anvanza opened this issue Mar 16, 2022 · 20 comments
Labels
Area: Product Component: ImportExport Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@anvanza
Copy link

anvanza commented Mar 16, 2022

Preconditions (*)

  1. Have an instance with Magento 2.4.3-p1
  2. Create 2 storeviews with 2 languages

Steps to reproduce (*)

  1. Create a product A with 25 customizable options and manage their order.
  2. Translate the title for each option for both storeviews.
  3. Make sure that each option has a different sku
  4. Save product A
  5. Create a product B, import options and select product A
  6. Save product B

Expected result (*)

  1. Product B has an exact copy of the customizable options of product A
  2. The titles are translated per storeview, the order is the exact same.

Actual result (*)

  1. The sortorder of the last 5 options is wrong, (also 0 in database) making them appear first.
  2. The titles are not translated and are a copy of the option sku
  3. I'm unable to sort options between pages

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2022

Hi @anvanza. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@anvanza
Copy link
Author

anvanza commented Mar 16, 2022

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @anvanza. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@anvanza
Copy link
Author

anvanza commented Mar 16, 2022

Reproduced this on the magento instance.
Created Product A with 25 options.
Screenshot 2022-03-16 at 11 18 31
Changed the titles on storeview 1
Screenshot 2022-03-16 at 11 19 14
Changed the titles on storeview 2
Created Product B and selected import from product A
Screenshot 2022-03-16 at 11 20 59
At first it seems imported correctly
Screenshot 2022-03-16 at 11 21 09
After clicking save
Screenshot 2022-03-16 at 11 21 38
The order has changed
Screenshot 2022-03-16 at 11 22 07
In other storeviews the titles dissappeared

@engcom-November engcom-November self-assigned this Mar 16, 2022
@m2-assistant
Copy link

m2-assistant bot commented Mar 16, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hi @anvanza ,
Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop above instance but cannot able to reproduce the issue.

  1. Created prodx with 25 options.
    image

  2. Changed all titles of options in both store views (Default and other store)

  3. Created prody by importing prodx options and Save
    No issue: Order of the options is same as created after saving and refresh
    image

All other store views - options are not disappeared.
image
@anvanza I see your Product B order has changed but the options are present in all store views.
Kindly recheck and elaborate the missing steps if any if the issue is still reproducible.
Thank you.

@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label Mar 16, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Mar 16, 2022
@engcom-November engcom-November added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Mar 16, 2022
@anvanza
Copy link
Author

anvanza commented Mar 16, 2022

Hi @engcom-November ,

Thank you for the collaboration. Verified the issue on Magento 2.4-develop above instance and I am able to reproduce the issue. See screenshots created in my last comment. Both products are on that same instance.

Option titles are dropped like shown on your screenshot.
The option order is screwed, look at product with SKU product_b.
I verified this on a local instance where I could also see that the database values for sort_order = 0 for the last 5 products.

@engcom-November
Copy link
Contributor

Verified the issue on Magento 2.4-develop branch again and the issue is reproducible.
Hence confirming the issue.
New Product B created by importing Product A options - Sorting order is changed before save and after save
Updated description of steps to reproduce.
image

image

@engcom-November engcom-November added Component: ImportExport Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Product Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. labels Mar 22, 2022
@m2-community-project m2-community-project bot removed the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Mar 22, 2022
@engcom-November engcom-November added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Mar 22, 2022
@m2-community-project m2-community-project bot moved this from Needs Update to Confirmed in Issue Confirmation and Triage Board Mar 22, 2022
@m2-community-project m2-community-project bot removed the Issue: needs update Additional information is require, waiting for response label Mar 22, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-2678 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Mar 22, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel engcom-Hotel added the Priority: P3 May be fixed according to the position in the backlog. label Mar 22, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Mar 22, 2022
@yogesh-valiya
Copy link
Member

@magento give me 2.4.3-p1 instance

@magento-deployment-service
Copy link

Hi @yvaliya. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

Hi @yvaliya, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

@yogesh-valiya
Copy link
Member

No problem, thanks anyway.

@engcom-Hotel
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @engcom-Hotel. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in Low Priority Backlog Jul 27, 2022
@github-jira-sync-bot github-jira-sync-bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: dev in progress labels Jul 28, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Done in Low Priority Backlog Aug 30, 2022
@m2-community-project m2-community-project bot removed the Progress: PR Created Indicates that Pull Request has been created to fix issue label Aug 30, 2022
@anvanza
Copy link
Author

anvanza commented Aug 30, 2022

@engcom-Hotel , Where can I find the PR ?

@engcom-Hotel
Copy link
Contributor

Hello @anvanza,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-2678 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-2678&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Product Component: ImportExport Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.3-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

5 participants