[Magento 2.4.4] Class Magento\Framework\Profiler\Driver\Standard\Stat not compatible with PHP 8.1

[guvra]

Preconditions (*)

1. Magento 2.4.4

Steps to reproduce (*)

1. In a custom module (in our case, a debug toolbar), call the method getFilteredTimerIds of the class Magento\Framework\Profiler\Driver\Standard\Stat.

Expected result (*)

1. The function returns an array of ordered timer ids

Actual result (*)

1. PHP crashes with the following error :

1 exception(s):
Exception #0 (Exception): Deprecated Functionality: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/vendor/magento/framework/Profiler/Driver/Standard/Stat.php on line 213

Exception #0 (Exception): Deprecated Functionality: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /var/www/html/vendor/magento/framework/Profiler/Driver/Standard/Stat.php on line 213
<pre>#1 strpos() called at [vendor/magento/framework/Profiler/Driver/Standard/Stat.php:213]
#2 Magento\Framework\Profiler\Driver\Standard\Stat->_getOrderedTimerIds() called at [vendor/magento/framework/Profiler/Driver/Standard/Stat.php:158]
#3 Magento\Framework\Profiler\Driver\Standard\Stat->getFilteredTimerIds() called at [app/code/Smile/DebugToolbar/Helper/Profiler.php:96]
#4 Smile\DebugToolbar\Helper\Profiler->prepareTimers() called at [app/code/Smile/DebugToolbar/Helper/Profiler.php:68]
#5 Smile\DebugToolbar\Helper\Profiler->computeStats() called at [app/code/Smile/DebugToolbar/Observer/AddToolbar.php:105]
#6 Smile\DebugToolbar\Observer\AddToolbar->execute() called at [vendor/magento/framework/Event/Invoker/InvokerDefault.php:88]
#7 Magento\Framework\Event\Invoker\InvokerDefault->_callObserverMethod() called at [vendor/magento/framework/Event/Invoker/InvokerDefault.php:74]
#8 Magento\Framework\Event\Invoker\InvokerDefault->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#9 Magento\Framework\Event\Invoker\InvokerDefault\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#10 Magento\Framework\Event\Invoker\InvokerDefault\Interceptor->Magento\Framework\Interception\{closure}() called at [app/code/Smile/DebugToolbar/Plugin/Event/Invoker.php:64]
#11 Smile\DebugToolbar\Plugin\Event\Invoker->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#12 Magento\Framework\Event\Invoker\InvokerDefault\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#13 Magento\Framework\Event\Invoker\InvokerDefault\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/Event/Invoker/InvokerDefault/Interceptor.php:23]
#14 Magento\Framework\Event\Invoker\InvokerDefault\Interceptor->dispatch() called at [vendor/magento/framework/Event/Manager.php:66]
#15 Magento\Framework\Event\Manager->dispatch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#16 Magento\Framework\Event\Manager\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#17 Magento\Framework\Event\Manager\Interceptor->Magento\Framework\Interception\{closure}() called at [app/code/Smile/DebugToolbar/Plugin/Event/Manager.php:52]
#18 Smile\DebugToolbar\Plugin\Event\Manager->aroundDispatch() called at [vendor/magento/framework/Interception/Interceptor.php:135]
#19 Magento\Framework\Event\Manager\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#20 Magento\Framework\Event\Manager\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/Event/Manager/Interceptor.php:23]
#21 Magento\Framework\Event\Manager\Interceptor->dispatch() called at [vendor/magento/framework/App/Http.php:131]
#22 Magento\Framework\App\Http->launch() called at [vendor/magento/framework/Interception/Interceptor.php:58]
#23 Magento\Framework\App\Http\Interceptor->___callParent() called at [vendor/magento/framework/Interception/Interceptor.php:138]
#24 Magento\Framework\App\Http\Interceptor->Magento\Framework\Interception\{closure}() called at [vendor/magento/framework/Interception/Interceptor.php:153]
#25 Magento\Framework\App\Http\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/App/Http/Interceptor.php:23]
#26 Magento\Framework\App\Http\Interceptor->launch() called at [vendor/magento/framework/App/Bootstrap.php:264]
#27 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:30]
</pre>

The error happens in the protected method _getOrderedTimerIds:

for ($j = $i + 1; $j < count($timerIds); $j++) {
    if (strpos($timerIds[$j], $prevTimerId . Profiler::NESTING_SEPARATOR) === 0) {
        $result[] = $timerIds[$j];
        /* Mark timer as already added */
        $timerIds[$j] = null;
    }
}

$timerIds[$j] is set to null at line 216, so the call to strpos at line 210 fails (strpos only accepts string values in PHP 8.1).

---

Please provide Severity assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @guvra. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @guvra,

We have tried to reproduce the issue in Magento 2.4.4 but for us, the issue is not reproducible. Please find attached the below custom module and let us know in case we have missed anything here.

FilterTimer.zip

We are using PHP 8.1 and Magento 2.4.4 in order to reproduce the issue. Let us know in case we have missed anything.

Thanks

[guvra]

@engcom-Hotel Hi,

You don't add any timer in your example, which is why you can't reproduce it.

Look at this loop in the Stat class:

for ($j = $i + 1; $j < count($timerIds); $j++) {
    if (strpos($timerIds[$j], $prevTimerId . Profiler::NESTING_SEPARATOR) === 0) {
        $result[] = $timerIds[$j];
        /* Mark timer as already added */
        $timerIds[$j] = null;
    }
}

There are situations where timerIds[$j] is set to null.
Then it is passed to the strpos function, which doesn't allow null values.

[engcom-Hotel]

Hello @guvra,

Thank you for your report and collaboration!

We have again tried to reproduce the issue by adding timers in the custom module and the issue is reproducible. We are getting the below error while running the custom module:

Hence confirming this issue.

Thanks