Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROMO code apply on the shipping showing null in graphql responce #35545

Closed
Abhay-Agrawal opened this issue May 27, 2022 · 11 comments
Closed

PROMO code apply on the shipping showing null in graphql responce #35545

Abhay-Agrawal opened this issue May 27, 2022 · 11 comments
Labels
Area: Cart & Checkout Component: GraphQL GraphQL Component: SalesRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Abhay-Agrawal
Copy link

Abhay-Agrawal commented May 27, 2022

As a ___ I want to ___ so that ___.

Steps to reproduce:

  1. Navigate to Marketing Menu-> Promotions -> Cart Price Rule

  2. Add the New Rule

  3. Add the One Rule and apply it on shipping Amount. Plz check the attached screenshot to add shipping rule
    Screenshot (1)

  4. apply the same PROMO code on the shipping amount

  5. check the graphql response

  6. showing discounts null
    "discounts": null,
    "discount": {
    "label": [
    "FreeShip"
    ],
    "amount": {
    "value": -15
    }
    },
    or
    Run cart graphql query:
    {
    cart(cart_id: "croja3eQTvZe2OI26BoMyN94N9B2z3Fd") {
    email
    items {
    uid
    prices {
    total_item_discount {
    value
    }
    price {
    value
    }
    discounts {
    label
    amount {
    value
    }
    }
    }
    product {
    name
    sku
    }
    quantity
    }
    applied_coupons {
    code
    }
    prices {
    discounts {
    amount {
    value
    }
    label
    }
    grand_total {
    value
    }
    }
    }
    }

    Expected result:
    All Graphql requests having discount field should return correct discount value in response

Additional Information:
Please refer the comment

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2022

Hi @Abhay-Agrawal. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Verified the issue on Magento 2.4-develop branch and discount amount applied on shipping amount is ignored. Only discount on product price is displayed in graphql response.
Steps performed:

  1. Created cart Price Rule Specific Coupon, Actions - 100 % discount and Apply to shipping amount - yes, Free shipping - For Shipments with matching items
    image
  2. Front-end - login as customer - Add product to cart and select Flat rate shipping methods.
  3. Apply discount
  4. Run the cart graphql query
    Issue: Total discount is displayed ignoring discount applied on Shipping amount
    image
    image
    While on UI - discount amount is displayed including the discount applied on shipping amount.

@engcom-November engcom-November added Component: SalesRule Component: GraphQL GraphQL Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: Cart & Checkout Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels May 27, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board May 27, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-3182 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented May 27, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@Abhay-Agrawal
Copy link
Author

It is same #31270

@artskirk
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @artskirk. Thank you for your request. I'm working on Magento instance for you.

@artskirk
Copy link

@magento I am working on this

@m2-community-project m2-community-project bot moved this from Ready for Development to Dev In Progress in High Priority Backlog Jun 30, 2022
@magento-deployment-service
Copy link

artskirk pushed a commit to artskirk/magento2-1-fork that referenced this issue Jul 4, 2022
artskirk pushed a commit to artskirk/magento2-1-fork that referenced this issue Jul 5, 2022
@artskirk artskirk mentioned this issue Jul 5, 2022
@m2-community-project m2-community-project bot moved this from Dev In Progress to Pull Request In Progress in High Priority Backlog Jul 5, 2022
@m2-community-project m2-community-project bot moved this from Pull Request In Progress to Ready for Development in High Priority Backlog Oct 13, 2022
@engcom-Charlie
Copy link
Contributor

As mentioned in PR, the internal team worked on this issue and committed in this revision.

Hence closing this issue.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Cart & Checkout Component: GraphQL GraphQL Component: SalesRule Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Project: GraphQL Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

5 participants