-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display zero tax configuration does not work in case of multiple shipping methods on Cart page #35561
Comments
Hi @pranayhbwsl. Thank you for your report.
Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:
For more details, review the Magento Contributor Assistant documentation. Add a comment to assign the issue: To learn more about issue processing workflow, refer to the Code Contributions.
🕙 You can find the schedule on the Magento Community Calendar page. 📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket. ✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel |
Hi @engcom-November. Thank you for working on this issue.
|
✅ Jira issue https://jira.corp.magento.com/browse/AC-3201 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
@magento I am working on this |
@magento give me 2.4-develop instance |
Hi @engcom-Lima. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Lima, here is your Magento Instance: https://1ee831d03ca92acb82a353361041180d.instances.magento-community.engineering |
@magento give me 2.4-develop instance |
Hi @isxam. Thank you for your request. I'm working on Magento instance for you. |
Hi @isxam, here is your Magento Instance: https://1ee831d03ca92acb82a353361041180d.instances.magento-community.engineering |
Hello, As I can see this issue got fixed in the scope of the internal Jira ticket AC-3201 by the internal team Based on the Jira ticket, the target version is 2.4.6. Thanks |
Preconditions and environment
Steps to reproduce
Expected result
Tax field with value 0.00 should not be visible in cart totals before selecting shipping methods.
Actual result
Tax field with value 0.00 is visible even before selecting shipping method.
![Screenshot from 2022-06-01 10-51-42](https://user-images.githubusercontent.com/77313820/171335135-07e9b238-babc-4a25-a028-047e53b94111.png)
Additional information
This issue happens because of strict equals operator in -> vendor/magento/module-tax/view/frontend/web/js/view/checkout/cart/totals/tax.js on line 24.
If we change it '==' the value '0.00' will also satisfy this condition and hide the tax field.
Same operator i.e., '==' is used in vendor/magento/module-tax/view/frontend/web/js/view/checkout/summary/tax.js for tax field zero value display check.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: