Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis + Sentinel + PHP8 #35634

Closed
1 of 5 tasks
Nuranto opened this issue Jun 17, 2022 · 8 comments
Closed
1 of 5 tasks

Redis + Sentinel + PHP8 #35634

Nuranto opened this issue Jun 17, 2022 · 8 comments
Labels
Area: Install & Administer Component: RedisMq Component: Session Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@Nuranto
Copy link
Contributor

Nuranto commented Jun 17, 2022

Preconditions and environment

  • Magento version 2.4.4
  • PHP8.1

Redis + Sentinel for session & cache

Steps to reproduce

Launch a command or page that use session or cache

Expected result

Everything's working fine

Actual result

Exception #0 (Exception): Deprecated Functionality: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /var/www/html/vendor/colinmollenhour/php-redis-session-abstract/src/Cm/RedisSession/Handler.php on line 300

Additional information

I reported the issue here : colinmollenhour/php-redis-session-abstract#47

When it will be solved, the magento's composer version requirement for this package should be updated.

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2022

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-assistant
Copy link

m2-assistant bot commented Jun 17, 2022

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-November
Copy link
Contributor

Hi @Nuranto ,
Thank you for reporting. Verified the issue on Magento 2.4.4 version with PHP 8.1.6 and redis configured but could not able to reproduce the issue.
image
image
Kindly elaborate steps / missing configuration details to reproduce the issue.
Thank you.

@engcom-November engcom-November added the Issue: needs update Additional information is require, waiting for response label Jun 17, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Needs Update in Issue Confirmation and Triage Board Jun 17, 2022
@engcom-November engcom-November added the Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch label Jun 17, 2022
@Nuranto
Copy link
Contributor Author

Nuranto commented Jun 17, 2022

Your sentinel_master and sentinel_servers are empty. To reproduce, you need to fill them

@engcom-November
Copy link
Contributor

engcom-November commented Jun 20, 2022

Verified the issue again on Magento 2.4-develop branch by filling sentinel_master and sentinel_servers values and the issue is reproducible.
Exception in var/log/system.log file: main.ERROR: Deprecated Functionality: preg_split(): Passing null to parameter #3 ($limit) of type int is deprecated in /var/www/html/magento2/vendor/colinmollenhour/php-redis-session-abstract/src/Cm/RedisSession/Handler.php on line 300 [] []
image

Unable to access UI anymore. Hence confirming this issue.

@engcom-November engcom-November added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: Session Component: RedisMq Area: Install & Administer Reported on 2.4.4 Indicates original Magento version for the Issue report. labels Jun 20, 2022
@m2-community-project m2-community-project bot removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch labels Jun 20, 2022
@engcom-November engcom-November added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Jun 20, 2022
@m2-community-project m2-community-project bot moved this from Needs Update to Confirmed in Issue Confirmation and Triage Board Jun 20, 2022
@m2-community-project m2-community-project bot removed the Issue: needs update Additional information is require, waiting for response label Jun 20, 2022
@engcom-Hotel engcom-Hotel added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Jun 21, 2022
@m2-community-project m2-community-project bot added this to Dev In Progress in High Priority Backlog Jun 21, 2022
@engcom-November engcom-November added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Install & Administer labels Jul 15, 2022
@engcom-November engcom-November added Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Install & Administer labels Jul 15, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.magento.com/browse/AC-5972 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Jul 15, 2022

✅ Confirmed by @engcom-November. Thank you for verifying the issue.
Issue Available: @engcom-November, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@engcom-Hotel
Copy link
Contributor

Hello,

As I can see this issue got fixed in the scope of the internal Jira ticket AC-5972 by the internal team
Related commits: https://github.com/magento/magento2/search?q=AC-5972&type=commits

Based on the Jira ticket, the target version is 2.4.6.

Thanks

@m2-community-project m2-community-project bot moved this from Ready for Development to Done in High Priority Backlog Oct 10, 2022
@m2-community-project m2-community-project bot added Progress: done and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Install & Administer Component: RedisMq Component: Session Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: done Reported on 2.4.4 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

No branches or pull requests

4 participants