Improve indexers

[Nuranto]

Preconditions and environment

Magento version 2.4.4

Steps to reproduce

1. Disable crons (to stop reindexing)
2. Add Color Product attribute for few products
3. Change indexers to "Update by Schedule" mode
4. Truncate catalog_product_category_cl table (optional, it's just easier to test with that step)
5. Open a product in admin area
6. Change the value for color attribute
7. Save product

Expected result

catalog_product_category_cl did not changed

Actual result

The product ID is added to catalog_product_category_cl, triggering a totally useless reindex on that product. (And a useless insert into cl table on product save)

Additional information

I used Product Category indexer as an example, but this issue seems to concern other indexer as well.

Subscription model should be refactored so we can edit easily update trigger statements per view, via a plugin for example. For this example (catalog_product_category), that would allow us to filter trigger on a specific attribute_id value(s)

#35685 (comment)

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash, unfortunately there is no ability to deploy Magento instance at the moment. Please try again later.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-November]

Hi @Nuranto ,
Thank you for reporting and collaboration. Verified the issue on Magento 2.4-develop branch but could not able to reproduce the issue.
Steps performed:

1. Disabled cron
2. Admin - System - Index Management - select all - Update by Schedule and Save
3. Truncate catalog_product_category_cl table
4. Edit existing product - Changed - Country of Manufacture and Saved
   No issue: Value changed as expected. No record in catalog_product_category_cl found.
   Kindly recheck the issue on Magento 2.4-develop branch and provide missing steps if any if the issue is still reproducible.
   Thank you.

[Nuranto]

Hi @engcom-November

I'm sorry, my example was wrong. I was testing on a custom attribute on my side, and gave you the first native select attribute I found, expected it will be an int. But country_of_manufacture is using varchar backend type, not int. With color attribute, you'll be able to reproduce.

Just tried with 2.4-develop branch and sample data (without cron setup).

Steps performed:

1. Admin - System - Index Management - select all - Update by Schedule and Save
2. Purge cache
3. Truncate catalog_product_category_cl table
4. Edit existing product (Joust Duffle Bag) - Changed "Color" and Saved

Issue : Seven rows appeared in catalog_product_category_cl, all for product "Joust Duffle Bag". Maybe some default values were not in the database, so I rerun the test :

5. Truncate catalog_product_category_cl table again
6. Edit existing product (Joust Duffle Bag) - Changed "Color" and Saved

Issue : One row appeared in catalog_product_category_cl, for product "Joust Duffle Bag". Which will trigger a useless reindex of category-product index on that product. Also, a useless insert into cl table is executed on product save.

[engcom-November]

Thanks for the update @Nuranto. Verified the issue again on Magento 2.4-develop branch with above mentioned steps and the issue is reproducible. Hence confirming the issue.