Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Braintree Paypal ON, CreditCard OFF. Broken checkout. #35961

Open
1 of 5 tasks
zhartaunik opened this issue Aug 17, 2022 · 20 comments
Open
1 of 5 tasks

Braintree Paypal ON, CreditCard OFF. Broken checkout. #35961

zhartaunik opened this issue Aug 17, 2022 · 20 comments
Assignees
Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for grooming Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@zhartaunik
Copy link
Contributor

Preconditions and environment

  • Magento version 2.4.5

Steps to reproduce

  1. Navigate to Stores / Configuration / Sales / Payment methods / Braintree section
  2. Fulfill all credentials for it and make Enable Card Payments = NO
  3. Navigate to Frontend.
  4. Add any product to the cart.
  5. Go to Checkout.
  6. Try to use PayPal payment method
    Screenshot from 2022-08-17 12-52-31
    .

Expected result

Paymen method should be selected and progress-bar should disappear.

Actual result

Endless progress-bar loading

JS Error in the console
adapter.js:66 Uncaught TypeError: Cannot read properties of undefined (reading 'clientToken')
at Object.getClientToken (adapter.js:66:66)

Additional information

The issue occurs because of not existing part of configuration which name is 'braintree'.
window.checkoutConfig.payment.braintree

This config is passing via the following PHP Class:
\PayPal\Braintree\Model\Ui\ConfigProvider::getConfig()

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2022

Hi @zhartaunik. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@zhartaunik
Copy link
Contributor Author

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @zhartaunik. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@engcom-Dash engcom-Dash self-assigned this Aug 17, 2022
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2022

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

    1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
      DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
    1. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
    1. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

@engcom-Dash engcom-Dash added the Reported on 2.4.5 Indicates original Magento version for the Issue report. label Aug 17, 2022
@zhartaunik
Copy link
Contributor Author

Please help me to understand. There is no Braintree section there. However according to vendor/composer/installed.json

"name": "magento/product-community-edition",
__"requires": "paypal/module-braintree": "4.4.0",
____"required": "paypal/module-braintree-core": "4.4.0",

I assume that it's not complete vanilla Magento version.

@engcom-Dash
Copy link

engcom-Dash commented Aug 17, 2022

Hi @zhartaunik ,

We are able to reproduce the issue in 2.4.5 magento instance and we are getting actual results like endless progress bar loading and JS error is appeared in console.

Screenshots for reference:

Screenshot from 2022-08-17 16-01-31

Steps to reproduce:

1.Navigate to Stores / Configuration / Sales / Payment methods / Braintree section
2.Fulfill all credentials for it and make Enable Card Payments = NO
3.Navigate to Frontend.
4.Add any product to the cart.
5.Go to Checkout.

We got same error----Like---->JS Error in the console
adapter.js:66 Uncaught TypeError: Cannot read properties of undefined (reading 'clientToken')

So we are confirming the issue in 2.4.5 magento instance.

Let us know if we are missing anything

Thanks!!!

@engcom-Dash engcom-Dash added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Area: Admin UI labels Aug 17, 2022
@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 17, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Aug 17, 2022
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Aug 17, 2022
@m2-community-project m2-community-project bot added Issue: ready for confirmation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Aug 17, 2022
@engcom-Dash engcom-Dash added the Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch label Aug 17, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 17, 2022
@engcom-Dash engcom-Dash added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 17, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Aug 17, 2022
@github-jira-sync-bot
Copy link

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 17, 2022
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Aug 17, 2022
@engcom-Dash engcom-Dash added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 17, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Aug 17, 2022
@Viktorja1
Copy link

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @Viktorja1. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@zhartaunik
Copy link
Contributor Author

@Viktorja1 I tried to reproduce but this vanilla magento doesn't contain a module braintree. I put the description above that there is a necessary dependency, but by some reason this module is absent.

@Viktorja1
Copy link

@zhartaunik Please try to reproduce this issue on 2.4.5 brunch only

@zhartaunik
Copy link
Contributor Author

@Viktorja1 in my vision magento from this branch differs from those magento which is installing via composer. It doesn't contain a dependency it must.

@AmyJZhao AmyJZhao removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 18, 2022
@m2-community-project m2-community-project bot moved this from Confirmed to Ready for Confirmation in Issue Confirmation and Triage Board Aug 18, 2022
@AmyJZhao AmyJZhao added the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Aug 18, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Aug 18, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6417 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Aug 18, 2022

✅ Confirmed by @AmyJZhao. Thank you for verifying the issue.
Issue Available: @AmyJZhao, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa sdzhepa added the Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. label Aug 18, 2022
@m2-community-project m2-community-project bot added this to Dev In Progress in High Priority Backlog Aug 18, 2022
@friendscottn
Copy link

It looks like there's an example of how to fix this on the older gene/module-braintree, but the fix is not available in the magento marketplace yet.

@EXTRA5POWER
Copy link

5388 4105 3200 7731
09/32
CVV 812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Admin UI Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P1 Once P0 defects have been fixed, a defect having this priority is the next candidate for fixing. Progress: ready for grooming Reported on 2.4.5 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
High Priority Backlog
  
Dev In Progress
Development

No branches or pull requests

8 participants