Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle options decimal qty is rendered as an integer part only #35964

Closed
2 of 5 tasks
say-my-name-user opened this issue Aug 17, 2022 · 10 comments · Fixed by #36231
Closed
2 of 5 tasks

Bundle options decimal qty is rendered as an integer part only #35964

say-my-name-user opened this issue Aug 17, 2022 · 10 comments · Fixed by #36231
Assignees
Labels
Area: Account Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@say-my-name-user
Copy link

say-my-name-user commented Aug 17, 2022

Preconditions and environment

  • Magento version: CE 2.4.4

Steps to reproduce

  1. Create a bundle product
  2. Allow "Qty Uses Decimals" in Advanced Inventory for bundle options
  3. Buy this bundle product with decimal options Qty like 1.5
  4. Check option Qty in the email / customer account / admin panel order details / invoice details / shipment details

Expected result

Bundle options Qty must be rendered everywhere according to amount you bought, in our case qty = 1.5

Actual result

Bundle options Qty is rendered only as an integer part, qty = 1

Additional information

This happens due to using sprintf('%d', $attributes['qty']), this '%d' makes it using only integer part.

Needs to be fixed at least in \Magento\Bundle\Block\Adminhtml\Sales\Order\Items\Renderer, \Magento\Bundle\Block\Adminhtml\Sales\Order\View\Items\Renderer and \Magento\Bundle\Block\Sales\Order\Items\Renderer

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2022

Hi @say-my-name-user. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@say-my-name-user say-my-name-user changed the title Bundle options decimal qty are rendered as integer part only Bundle options decimal qty is rendered as an integer part only Aug 17, 2022
@engcom-Delta engcom-Delta self-assigned this Aug 17, 2022
@m2-assistant
Copy link

m2-assistant bot commented Aug 17, 2022

Hi @engcom-Delta. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Delta
Copy link
Contributor

Hi @say-my-name-user ,
Thank you for raising an issue , we tried to reproduce the issue on magento 2.4.4 instance , unfortunately we could not find step# 2 from Advanced inventory section. Kindly review the provided steps.

Screenshot 2022-08-22 at 5 23 54 PM

Screenshot 2022-08-22 at 5 23 25 PM

@engcom-Delta engcom-Delta added Issue: needs update Additional information is require, waiting for response and removed Issue: ready for confirmation labels Aug 22, 2022
@say-my-name-user
Copy link
Author

Hi @engcom-Delta,

you should check Advanced Inventory in the bundle options product, the simple product that is attached to the bundle, not bundle itself.

@engcom-Delta
Copy link
Contributor

Hi @say-my-name-user ,
Sorry to come back to you again , unfortunately we could not find out such options on magento 2.4 develop instance.
Please find the attached video for reference and correct me if i am wrong.

https://www.loom.com/share/e2d6ecbd46fa4ef48b07e9e2c4d5251c

@say-my-name-user
Copy link
Author

say-my-name-user commented Aug 25, 2022

Hi, you've got me wrong @engcom-Delta,

again, this option is NOT in the bundle product itself but in the SIMPLE product(s) that bundle consists of.

Products - Inventory - Catalog - Magento Admin 2022-08-25 15-25-39
Products - Inventory - Catalog - Magento Admin 2022-08-25 15-26-57

@engcom-Delta
Copy link
Contributor

Hi @say-my-name-user ,
Thank you for providing more clear snapshots to understand the steps. We tried to reproduce the issue on Magento 2.4 develop instance , found that on Admin panel after placing an order quantity has been displayed as 1.5 only for order details section,invoiced section but after receiving an email , on order confirmation email it(quantity) has been showing as 1 instead of 1.5 . Hence issue has been confirmed.

Please find the attached video for reference and screenshots.

Screenshot 2022-08-25 at 8 05 52 PM

Screenshot 2022-08-25 at 8 08 02 PM

Screenshot 2022-08-25 at 8 08 38 PM

https://www.loom.com/share/af78008d78ae46a5b453cda2f59c161a

@engcom-Delta engcom-Delta added Area: Account Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch and removed Issue: needs update Additional information is require, waiting for response labels Aug 25, 2022
@engcom-Delta engcom-Delta added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: ready for confirmation labels Aug 25, 2022
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6548 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Aug 25, 2022

✅ Confirmed by @engcom-Delta. Thank you for verifying the issue.
Issue Available: @engcom-Delta, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@say-my-name-user
Copy link
Author

say-my-name-user commented Aug 25, 2022

Thank you @engcom-Delta ,

but you mentioned only "Qty" column where the number is correct but pay attention to the "Product" column on the order/invoice details page.

This columns has a bundle option title in the format like "qty x product_name" and qty is also incorrect there, "1 x Joust Duffle Bag" instead of "1.5 x Joust Duffle Bag".

The same issue is in the email option title.

@sdzhepa sdzhepa added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Aug 25, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Account Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants