Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin order emails send even when 'Email order confirmation' is unchecked #36256

Closed
github-jira-sync-bot opened this issue Oct 7, 2022 · 11 comments
Labels
Area: Order Evaluated Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.

Comments

@github-jira-sync-bot
Copy link

Issue:
Admin order emails send even when 'Email order confirmation' is unchecked

 

Steps to reproduce:

  • Create a customer account or register as a customer (for the purpose of creating an admin order).
  • Go to Sales > Order and click on "Create New Order".
  • Select the customer, add the products to the order, fill in the address, and select the Shipping and Payment methods.
  • Before submitting the order, untick the "Email Order Confirmation" check box.
  • Click on "Submit Order" to create the order.

Actual result:
An order confirmation email is sent regardless of the unticked "Email Order Confirmation" check box.

Expected result:
An order confirmation email should not be sent if the "Email Order Confirmation" check box is unticked while order creation.

Additional information:

  • If we tick the "Email Order Confirmation" check box, two emails are sent to the customer.
  • This checkbook state is being honored during the Invoice and Shipment creation, so this behavior in Order creation is inconsistent.
@github-jira-sync-bot github-jira-sync-bot added Evaluated Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. labels Oct 7, 2022
@github-jira-sync-bot
Copy link
Author

The issue was exported from the internal Jira. The link to the original Jira issue: https://jira.corp.adobe.com/browse/ACP2E-1200

@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2022

Hi @github-jira-sync-bot. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.


⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added this to Ready for Confirmation in Issue Confirmation and Triage Board Oct 7, 2022
@m2-community-project m2-community-project bot added Issue: ready for confirmation Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 7, 2022
@github-jira-sync-bot github-jira-sync-bot removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Oct 7, 2022
@github-jira-sync-bot
Copy link
Author

Unfortunately, not enough information was provided to create a Jira ticket. Please make sure you added the following label(s): Reproduced on 2.4.x, ^Area:.*

Once all required labels are present, please add Issue: Confirmed label again.

@o-iegorov o-iegorov added Area: Order Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Oct 7, 2022
@m2-community-project m2-community-project bot moved this from Ready for Confirmation to Confirmed in Issue Confirmation and Triage Board Oct 7, 2022
@github-jira-sync-bot
Copy link
Author

✅ Jira issue https://jira.corp.adobe.com/browse/AC-6831 is successfully created for this GitHub issue.

@m2-assistant
Copy link

m2-assistant bot commented Oct 7, 2022

✅ Confirmed by @o-iegorov. Thank you for verifying the issue.
Issue Available: @o-iegorov, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@sdzhepa sdzhepa added the Priority: P3 May be fixed according to the position in the backlog. label Oct 13, 2022
@m2-community-project m2-community-project bot added this to Ready for Development in Low Priority Backlog Oct 13, 2022
@ankitsrivastavacedcoss
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-deployment-service
Copy link

Hi @ankitsrivastavacedcoss. Thank you for your request. I'm working on Magento instance for you.

@magento-deployment-service
Copy link

@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Oct 18, 2022
@m2-community-project m2-community-project bot moved this from Ready for Development to Pull Request In Progress in Low Priority Backlog Oct 18, 2022
@chittima
Copy link
Contributor

Internal team is working on this issue

@hostep
Copy link
Contributor

hostep commented Nov 15, 2022

Closed without a comment explaining why?

But it's probably fixed by https://github.com/magento/magento2/search?q=ACP2E-1200&type=commits ...

@chittima
Copy link
Contributor

Issue is already fixed in the develop branch and not reproducible anymore. Here is the commit 1de1cea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Order Evaluated Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround.
Projects
Development

No branches or pull requests

6 participants