Email template displayed incorrectly when using depend inside an if

[igi8819]

Preconditions and environment

• Magento version: 2.4.5-p1
• Magento version: 2.4.4-p2

Steps to reproduce

1. Go to admin -> marketing -> email templates
2. Click Add new email template
3. Load Default Template form "New Order"

Add these lines before greeting/or wherever you want
{{if order_id}} {{depend order_id}} {{trans 'My order id is: <span class="no-link">%order_id</span>.' order_id=$order_id |raw}} {{/depend}} {{/if}}

So looks like this:

{{if order_id}} {{depend order_id}} {{trans 'My order id is: <span class="no-link">%order_id</span>.' order_id=$order_id |raw}} {{/depend}} {{/if}} <p class="greeting">{{trans "%customer_name," customer_name=$order_data.customer_name}}</p> Save email template and go to stores -> configuration -> sales -> sales emails Add this new email template to "New Order Confirmation Template" than save it Clear cache Place and order in frontend and see the email content. The if condition is not processed. I see that this in 2.4.5 (without p2) it is working. Probably the issue is in the filter function, which is in the vendor/magento/framework/Filter/Template.php file When i compare this with 2.4.5 version it way to different 2.4.5-p2 2.4.5 Expected result if condition in email template processed correctly Actual result if condition in email template not processed correctly Additional information this issue also happening on Magento 2.4.4-p2 Release note No response Triage and priority Severity: S0 - Affects critical data or functionality and leaves users without workaround. Severity: S1 - Affects critical data or functionality and forces users to employ a workaround. Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround. Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround. Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @igi8819. Thank you for your report.
To speed up processing of this issue, make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, review the Magento Contributor Assistant documentation.

Add a comment to assign the issue: @magento I am working on this

To learn more about issue processing workflow, refer to the Code Contributions.

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

[m2-assistant]

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
     Details

     If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.
• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.4-develop branch

  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Add label Issue: Confirmed once verification is complete.

• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @igi8819,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop and 2.4.5 instances and the issue is not reproducible on both the instances.Email Template Displayed Correctly.Kindly refer the screenshots.

Steps to reproduce :

1.Go to admin -> marketing -> email templates
2.Click Add new email template
3.Load Default Template form "New Order"
4.Add these lines before greeting/or wherever you want
{{if order_id}} {{depend order_id}} {{trans 'My order id is: <span class="no-link">%order_id</span>.' order_id=$order_id |raw}} {{/depend}} {{/if}}.
5.Save email template and go to stores -> configuration -> sales -> sales emails
6.Add this new email template to "New Order Confirmation Template" than save it
7.Clear cache
8.Place and order in frontend and see the email content.

Kindly recheck the behavior on Magento 2.4-develop instance and elaborate steps to reproduce if the issue is still reproducible.

Thanks.

[igi8819]

I mentioned that in 2.4.5 and 2.4.4 is WORKING!

Not Working in:

• 2.4.5-p1
• 2.4.4-p2

So please test in 2.4.5-p1 and 2.4.4-p2 (security version)

[engcom-Bravo]

Hi @igi8819,

Thanks for your Update.

As per steps to reproduce the issue is reproducible in 2.4.5-p1 and 2.4.4-p2, but it is recommended to verify the issue on Magento 2.4-develop instance as it is an upcoming 2.4.x release and have latest code base.

we can accept the issues if they are reproducible in 2.4-develop branch.

Thanks.