Skip to content

[Issue] Remove redundant getCacheTags method from the Topmenu class #36643

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #35846: Remove redundant getCacheTags method from the Topmenu class


Description (*)

Remove redundant getCacheTags method from the Topmenu class as it is unneeded:
The getCacheTags() method from Topmenu class:
https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/Theme/Block/Html/Topmenu.php#L365
return array_merge(parent::getCacheTags(), $this->getIdentities()); which already returned by the parent method:
https://github.com/magento/magento2/blob/2.4-develop/lib/internal/Magento/Framework/View/Element/AbstractBlock.php#L1058

Related Pull Requests

Fixed Issues (if relevant)

  1. N/A

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: UI FrameworkComponent: ThemeIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branch

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions