-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: FrameworkComponent: AdminIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Progress: doneReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
This issue is automatically created based on existing pull request: #36422: Only Update Indexer Mode When Required
Description (*)
Updates the indexer mode change mass actions to only change modes when required i.e. when the current index mode is different to the one being applied. This prevents unnecessary trips to the database.
Also updates the messaging displayed to the admin to inform them how many indexers were updated and how many were skipped thanks to this change.
Finally, replaces the deprecated addSuccess()
function with the non-deprecated addSuccessMessage()
function for the message manager class when displaying the changed messages to the admin.
Manual testing scenarios (*)
- Log into the admin
- Set any number of indexers to be
Update on Schedule
- Observe the success message to confirm the correct number of indexers were updated versus skipped, based on their original mode
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Area: FrameworkComponent: AdminIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Progress: doneReproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch