-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: SEOArea: UI FrameworkComponent: StoreIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
This issue is automatically created based on existing pull request: #36414: Do not use store code in URLs when site is in single store mode
Description (*)
We have a store in single store mode. When we do setup:install, the config option web/url/use_store
is enabled, which causes the store code to appear in the URL, even though there is only one storeview. This change makes sure the storecode does not appear in the URL when a store is in single store mode.
Manual testing scenarios (*)
- Set a store with one store view in Single Store Mode (
bin/magento config:set general/single_store_mode/enabled 1
) and enable store codes (bin/magento config:set web/url/use_store 1
) - Visit the homepage
- You can see the store code in the URL
- Apply this patch
- Visit the homepage
- Store code is not there
Questions or comments
Contribution checklist (*)
- Pull request has a meaningful description of its purpose
- All commits are accompanied by meaningful commit messages
- All new or changed code is covered with unit/integration tests (if applicable)
- README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
- All automated tests passed successfully (all builds are green)
Metadata
Metadata
Assignees
Labels
Area: SEOArea: UI FrameworkComponent: StoreIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P3May be fixed according to the position in the backlog.May be fixed according to the position in the backlog.Progress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch