Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] Do not use store code in URLs when site is in single store mode #36831

Closed
5 tasks done
m2-assistant bot opened this issue Feb 9, 2023 · 2 comments · Fixed by #36414
Closed
5 tasks done

[Issue] Do not use store code in URLs when site is in single store mode #36831

m2-assistant bot opened this issue Feb 9, 2023 · 2 comments · Fixed by #36414
Assignees
Labels
Area: SEO Area: UI Framework Component: Store Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Feb 9, 2023

This issue is automatically created based on existing pull request: #36414: Do not use store code in URLs when site is in single store mode


Description (*)

We have a store in single store mode. When we do setup:install, the config option web/url/use_store is enabled, which causes the store code to appear in the URL, even though there is only one storeview. This change makes sure the storecode does not appear in the URL when a store is in single store mode.

Manual testing scenarios (*)

  1. Set a store with one store view in Single Store Mode (bin/magento config:set general/single_store_mode/enabled 1) and enable store codes (bin/magento config:set web/url/use_store 1)
  2. Visit the homepage
  3. You can see the store code in the URL
  4. Apply this patch
  5. Visit the homepage
  6. Store code is not there

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added the Priority: P3 May be fixed according to the position in the backlog. label Feb 9, 2023
@m2-community-project m2-community-project bot added this to Pull Request In Progress in Low Priority Backlog Feb 9, 2023
@engcom-Lima engcom-Lima added Component: Store Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Reported on 2.4.x Indicates original Magento version for the Issue report. Area: SEO Area: UI Framework Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed labels Feb 9, 2023
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-7923 is successfully created for this GitHub issue.

@m2-assistant
Copy link
Author

m2-assistant bot commented Feb 9, 2023

✅ Confirmed by @engcom-Lima. Thank you for verifying the issue.
Issue Available: @engcom-Lima, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SEO Area: UI Framework Component: Store Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.x Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants