-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMS Block content is not updated according to page builder changes during CMS Block save #37514
Comments
Hi @Aleksejs-Prjahins. Thank you for your report.
Join Magento Community Engineering Slack and ask your questions in #github channel. |
Hi @engcom-November. Thank you for working on this issue.
|
@magento give me 2.4-develop instance |
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-November, here is your Magento Instance: https://1aae38da74df1eae22b51de9ebef114c.instances-prod.magento-community.engineering |
Probably related to #34898 - I have a similar issue, it only happens on Chrome. Try FireFox or other browsers |
@magento give me 2.4-develop instance |
Hi @engcom-November. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-November, here is your Magento Instance: https://1aae38da74df1eae22b51de9ebef114c.instances-prod.magento-community.engineering |
Hi @Aleksejs-Prjahins , |
I have same issue on Magento 2.4.6 |
Hey, I can confirm that we also got this on our 2.4.4-p3 commerce instance. This behavior can be noticed when saving contents of: block/dynamic block/cms page This occurs very randomly, it's very hard to reproduce this. Pretty sure it's not the browser issue as I was trying to reproduce this on firefox/chrome/safari/edge and it happened to me on all of those browsers, but only few times. I'm pretty sure I was never able to reproduce this when I had my devtools opened. |
@Aleksejs-Prjahins were you able to solve the issue or at least find a reproducible scenario? |
we have this same issue on our magento instance.
This issue first occured a 2-3 months ago on our pre-update version 2.3.5. It as well occurs on magento v.2.4.4-p2 (but only on our B2B shop | B2C magento instance with the same version is working fine) |
Error occurs randomly and it is caused due to wrong order loading js scripts. index f7a5d86..e234b84 100644
--- a/view/adminhtml/requirejs-config.js
+++ b/view/adminhtml/requirejs-config.js
@@ -22,6 +22,9 @@ var config = {
},
'Magento_PageBuilder/js/resource/jquery/ui/jquery.ui.touch-punch': {
deps: ['jquery/ui']
+ },
+ 'Magento_PageBuilder/js/form/element/wysiwyg': {
+ deps: ['Magento_Ui/js/form/form']
}
},
config: { magento 2.4.4 and magento/module-page-builder 2.2.2 |
This one seems to really work and fix the issue 😲 |
Closing the full-screen editing view in PageBuilder and then quickly clicking the save button seems to make this issue more likely to be reproduced |
@magento give me 2.4-develop instance |
Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you. |
Hi @engcom-Dash, here is your Magento Instance: https://1aae38da74df1eae22b51de9ebef114c.instances-prod.magento-community.engineering |
Verified the issue again on Magento 2.4-develop instance with enterprise edition and B2B modules enabled and the issue is reproducible with below steps performed: |
✅ Jira issue https://jira.corp.adobe.com/browse/AC-8989 is successfully created for this GitHub issue. |
✅ Confirmed by @engcom-November. Thank you for verifying the issue. |
❌ You don't have permission to export this issue. |
Hey, as for Today I was able to make some new findings. In my case, it happened for me very rarely in the first place when I had developer mode & I didn't have any cache stuff in var/view_processed. I tried the patch proposed above by @lukas19944 . |
Explanation:
If you are required to make changes and none of the above Solutions work, you can modify the post request content and adjust the HTML code of the Pagebuilder. (A tedious workaround, but does the trick if everything else doesn't work) |
I'm also facing the same issue. How can I override magento/module-page-builder/view/adminhtml/requirejs-config.js and add this snippet? As It should not be added directly in vendor. Please can someone let me know? |
@lukas19944 @n0kit31 how did you guys override default magento/module-page-builder/view/adminhtml/requirejs-config.js and resolved this issue? Please can you help? |
I have debugged this behavior a little bit and, seems, found the cause of such intermittent behavior. There is the following mixin related to registration of page builder instances and further form submit activities: Also, there is a WYSIWYG form element described in the Currently, there is no any direct relationships between these elements: In rare cases So, to be more precise, the following dependency could be added: @samvens you can add appropriate dependency into custom requirejs-config.js file in scope of custom extension var config = {
shim: {
'Magento_PageBuilder/js/form/element/wysiwyg': {
deps: ['Magento_PageBuilder/js/form/form-mixin']
}
},
} or var config = {
shim: {
'Magento_PageBuilder/js/form/element/wysiwyg': {
deps: ['Magento_Ui/js/form/form']
}
},
} |
The issue's reproducibility was assessed by creating a block with numerous rows, columns, headings, and text fields across default, developer, and production modes in 2.4-develop. Screen.Recording.2023-11-29.at.6.04.49.PM.movThanks. |
try to use someting like https://github.com/cweagans/composer-patches |
Have you fix the issue @jeyoor ?
Have you fix the issue @KrzysztofWisniewskiAcc ? |
Preconditions and environment
Steps to reproduce
Expected result
CMS Block content is saved and a success message appears.
Actual result
A success message appears, but CMS Block content stays as it was before.
Screen.Recording.2023-05-18.at.17.09.59-1.mov
Additional information
During investigation been found that when the save button was clicked content of the page builder which was transported to the hidden input field is old.
Also, the issue appears randomly, sometimes content is saved, sometimes not.
Release note
No response
Triage and priority
The text was updated successfully, but these errors were encountered: