[Issue] Fix for headers in HTTP Curl Adapter

[m2-assistant]

This issue is automatically created based on existing pull request: #37613: Fix for headers in HTTP Curl Adapter

---

Description (*)

Current implementation of Magento Curl Adapter for Laminas_Http trying to set headers in associative array format:

[
    'Content-Type': 'application/json'
]

We instead should have indexed array:

[
    'Content-Type: application/json',
]

Related Pull Requests

Fixed Issues (if relevant)

n/a

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[dariodor]

I found the same issue on Magento EE v2.4.6 (framework 103.0.6): all our Http requests fail because they do not have headers.
As Described in PHP documentation (https://www.php.net/manual/en/function.curl-setopt.php) CURLOPT_HTTPHEADER option value must be "An array of HTTP header fields to set, in the format array('Content-type: text/plain', 'Content-length: 100')".
Basically, the value must be an array of strings, not an associative array.
Finger crossed for a rapid merge of the pull request! 🤞

[bigbangx]

Same issue here.

I don't understand how this has been validated.

[engcom-November]

Hello @zalazdi,

Thank you for the report and collaboration!

We were able to send curl requests with headers without any problem.
Can you elaborate the issue you are facing, and where is this causing the problem.

[m2-assistant]

Hi @engcom-November. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[zalazdi]

@engcom-November
It's not setting headers in current implementation.

In Laminas\Http\Client@prepareHeaders - we're getting associative array.
Than in Magento\Framework\HTTP\Adapter@write it's custom implementation for this curl adapter - when we're trying to put this associative array for CURLOPT_HEADER.

In original Laminas adapter it's done how in mine PR:
laminas/laminas-http@81181e0

Fast way to verify how PHP implements curl headers:

<?php

$headers = [
    'Content-Type' => 'application/json',
];

$ch = curl_init('https://magento.requestcatcher.com');
curl_setopt($ch, CURLOPT_POST, true);
curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);

$response = curl_exec($ch);

And on https://magento.requestcatcher.com - it's wrong header.

With

$headers = [
    'Content-Type: application/json',
];

works great.

[engcom-November]

Hello @zalazdi,

Thank you for the quick response!

The headers are not being set because in the implementation lib/internal/Magento/Framework/HTTP/Adapter/Curl.php the headers are associative array. It needs to be an indexed array.
Hence confirming this issue.

Thank you.