[Issue] Remove unnecessary cache manipulation during setup

[m2-assistant]

This issue is automatically created based on existing pull request: #38123: Remove unnecessary cache manipulation during setup

---

Description

When running bin/magento setup:db-data:upgrade (or bin/magento setup:upgrade), Magento turns off some caches, then re-enables the same. This causes Magento to write out its configuration to disk, but this step seems unnecessary and is causing some issues with downstream modules which observe this event (write deployment configuration to disk) because it is not necessary at this step. Relevant caches are already cleared later on in the process, so turning them off and then back on again seems redundant.

I can't work out why this was added. The best I can find is the initial commit (96a2e17), which says "MC-30236: Upgrade from 2.3.x CE with SD to 2.3.x EE AreaCode Exception". MC-30263 seems like a reference to a ticket, but I don't have any visibility on this. I don't see any tests associated with this commit to demonstrate the bug it claims to resolve. The description of the supposed bug ("AreaCode Exception") suggests that this action (disable/enable caches) is not the correct resolution anyway. This pull request effectively removes all changes related to that ticket from this repository.

For my reference later, the specific case which we were investigating (which lead me back to this) was https://gitlab.hyva.io/hyva-themes/magento2-theme-module/-/blob/main/src/Plugin/HyvaModulesConfig/UpdateOnModuleStatusChange.php?ref_type=heads#L40 being called during during deployment, which over-wrote the file we stored in version control.

Manual testing scenarios

1. Environment file gets regenerated as expected.
   1. Add a code comment to app/etc/env.php
   2. Run bin/magento cache:disable layout && bin/magento cache:enable
   3. Review the content of app/etc/env.php to see that the file has been regenerated.
2. Environment file does not get regenerated during setup commands
   1. Add a code comment to app/etc/env.php
   2. Run bin/magento setup:db-data:upgrade
   3. Review the content of app/etc/env.php to see that the file has not been modified.
   4. Run bin/magento setup:upgrade
   5. Review the content of app/etc/env.php to see that the file has not been modified.

Questions or comments

I am happy to learn more about why this code was initially added. It may be that the bug this was intended to fix no longer exists, or that there is a better way to fix that bug if it still remains.

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @fredden,

Thanks for the report and collaboration!

We have tried to reproduce the issue in the Magento 2.4-develop branch and the issue is reproducible for us. Each time when we are running bin/magento setup:upgrade or bin/magento setup:db-data:upgrade, app/etc/env.php regenerated each time.

Hence confirming the issue.

Thanks

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10396 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.