Category::getUrl() should not fetch 301 redirect

[kweij]

Preconditions and environment

• Magento version: 2.4.6-p3

Steps to reproduce

1. Create a category in the Admin
   URL Key is now auto-generated, system/auto-generated URL Rewrite is created (redirect_type = 0)
2. Change category URL Key
   System/auto-generated URL Rewrite is updated to a 301 from old to new (redirect_type = 301)
   A new system/auto-generated URL Rewrite is added (redirect_type = 0) from new tot internal route
3. Enable canonical URLs
   bin/magento config:set catalog/seo/category_canonical_tag 1
4. View the category in the frontend

State in the database with example data:

Expected result

Canonical URL === New category URL Key

Actual result

Canonical URL === Old category URL Key

Additional information

In \Magento\Catalog\Model\Category.php::getUrl() URL rewrites are loaded for the category by ID and store. This returns the first result, which is the 301 redirect from the old to the new category URL. The request_path of this rewrite is used to form the return value of Category.php:getUrl(), which contains the old URL.

The fix is that only the system/auto-generated URL rewrite is loaded. Therefor the array param provided to \Magento\UrlRewrite\Model\UrlFinderInterface::findOneByData() in vendor/magento/module-catalog/Model/Category.php:613 should be extended with UrlRewrite::REDIRECT_TYPE => 0,. The same addition is already in place for \Magento\Catalog\Model\Product\Url::getProductUrl(), but missing for categories.

Release note

Note that I've only yet encountered this issue in the category canonicals, but since the issue resides in Category.php:getUrl(), there are probably other area's where this bug causes an issue.

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @kweij. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[kweij]

@magento The issue is reproducible on the vanilla Magento instance

[engcom-Bravo]

Hi @kweij,

Thank you for reporting and collaboration.

Verified the issue on Magento 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

• Create a category in the Admin
• URL Key is now auto-generated, system/auto-generated URL Rewrite is created (redirect_type = 0)
• Change category URL Key
• System/auto-generated URL Rewrite is updated to a 301 from old to new (redirect_type = 301)
• A new system/auto-generated URL Rewrite is added (redirect_type = 0) from new tot internal route
• Enable canonical URLs
• bin/magento config:set catalog/seo/category_canonical_tag 1
• View the category in the frontend

In frontend the category url is changed to new url key but the canonical url is still in old url key.

Hence Confirming the issue.

Thanks.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10464 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[hostep]

Seems to be fixed by ACP2E-2481: Category Canonical URLs not working, so we can close this issue down I guess.

[engcom-Bravo]

Hi @kweij,

The issue is fixed under this commits : https://github.com/search?q=repo%3Amagento%2Fmagento2+ACP2E-2481&type=commits

Hence we are Closing this issue.

Thanks.