Skip to content

[Issue] refactor quote address do validate method #38230

@m2-assistant

Description

@m2-assistant

This issue is automatically created based on existing pull request: #38219: refactor quote address do validate method


Description (*)

While debugging address validation I noticed that \Magento\Quote\Model\QuoteAddressValidator::doValidate needs to be refactored and optimized.

My PR includes readability improvements to thedoValidate method

Related Pull Requests

Manual testing scenarios (*)

  1. Add a product to the shopping cart
  2. Go to the shopping cart

Questions or comments

I think that the exceptions thrown are not relevant in this case and the messages like Invalid customer address id %1 are not clear. I think we need to change it as well.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

Metadata

Metadata

Assignees

Labels

Area: FrameworkComponent: QuoteIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.Progress: PR in progressProgress: doneReported on 2.4.xIndicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchTriage: Dev.ExperienceIssue related to Developer Experience and needs help with Triage to Confirm or Reject it

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions