Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue] [vcl] don't manually interfere with compression #38309

Closed
5 tasks
m2-assistant bot opened this issue Dec 21, 2023 · 5 comments · Fixed by #38211
Closed
5 tasks

[Issue] [vcl] don't manually interfere with compression #38309

m2-assistant bot opened this issue Dec 21, 2023 · 5 comments · Fixed by #38211
Assignees
Labels
Area: Framework Component: PageCache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@m2-assistant
Copy link

m2-assistant bot commented Dec 21, 2023

This issue is automatically created based on existing pull request: #38211: [vcl] don't manually interfere with compression


Description (*)

Varnish already has default compression handling. This code only kicks into gear in case of a miss or a pass, and in those cases, the backend should be responsible for these.

Manual testing scenarios (*)

automated testing should do the job

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)
@m2-assistant m2-assistant bot added Component: PageCache Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Dec 21, 2023
@m2-community-project m2-community-project bot added this to Pull Request In Progress in High Priority Backlog Dec 21, 2023
@engcom-Hotel engcom-Hotel self-assigned this Jan 15, 2024
Copy link
Author

m2-assistant bot commented Jan 15, 2024

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Hotel
Copy link
Contributor

Hello @gquintard,

Thanks for the report and collaboration!

We have tried to proceed with this issue and its related PR but we are getting the Failed test result. Please go through the below comment for more information:

#38211 (comment)

Thanks

@engcom-Hotel engcom-Hotel added the Issue: needs update Additional information is require, waiting for response label Jan 15, 2024
@gquintard
Copy link
Contributor

Hi,

Yes, this is the same issue as the other VCL ticket. Something on Mac is weird, I will get my hand on an Apple laptop and will track that down

@engcom-Hotel engcom-Hotel added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Area: Framework and removed Issue: needs update Additional information is require, waiting for response labels Jan 22, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-10884 is successfully created for this GitHub issue.

Copy link
Author

m2-assistant bot commented Jan 22, 2024

✅ Confirmed by @engcom-Hotel. Thank you for verifying the issue.
Issue Available: @engcom-Hotel, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Framework Component: PageCache Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: done Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
Development

Successfully merging a pull request may close this issue.

3 participants