[Issue] Sales Rules regression in 2.4.7

[Nuranto]

Preconditions and environment

• Magento version 2.4.7

Steps to reproduce

1. Create a sales rule with :
   • Coupon code = test
   • No limitation
   • No conditions
   • Action = Fixed amount for whole cart, 1€ discount
   • Apply to Shipping Amount = yes
   • Product condition = name equals to "any_text_that_is_not_a_product_name"
2. Apply 'test' coupon to a frontend cart with a shipping amount.

Expected result

Rule is applied. Discount of 1€ is applied on shipping amount

Actual result

Cannot add coupon to cart (invalid coupon)

Additional information

We had rules like this to add discount on shipping amount (and shipping amount only). It worked perfectly in previous versions, but does not work anymore in 2.4.7.

Regression happened in this commit : 79d57b4 where line $this->rulesApplier->maintainAddressCouponCode($address, $rule, $this->getCouponCode()); has been removed. @sivaschenko / @bl4de : was there a reason ?

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @Nuranto. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:

• @magento give me 2.4-develop instance - upcoming 2.4.x release
• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Dash. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
     Details

     - Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
     - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
     - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

---

• Join Magento Community Engineering Slack and ask your questions in #github channel.

[engcom-Dash]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @engcom-Dash. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @engcom-Dash, here is your Magento Instance: https://93af9f9cd29e6a619d3f129b984079ca.instances-prod.magento-community.engineering
Admin access: https://93af9f9cd29e6a619d3f129b984079ca.instances-prod.magento-community.engineering/admin_89ea
Login: 70c9fc67
Password: c0dbb1648b2d

[engcom-Dash]

Hi @Nuranto

Thanks for reproting and collaboration.

Verified the issue on both 2.4 dev and 2.4.7 instances but the issue is not reproducable.

Steps to reproduce

1. Create a sales rule with :

Coupon code = test
No limitation
No conditions
Action = Fixed amount for whole cart, 1€ discount
Apply to Shipping Amount = yes
Product condition = name equals to "any_text_that_is_not_a_product_name"

2. Apply 'test' coupon to a frontend cart with a shipping amount.

We are able to apply the coupon code successfully.

Please refer the attached screenshots. Let us know if we missed anything.

[Nuranto]

Hello @engcom-Dash
On your Magento Instance, there's not product condition :

I added one :

And now :

[engcom-Dash]

Hi @Nuranto

Verified the issue on magento 2.4 dev instance and the issue is reproducible.

Steps to reproduce

Create a sales rule with :
Coupon code = test
No limitation
No conditions
Action = Fixed amount for whole cart, 1€ discount
Apply to Shipping Amount = yes
Product condition = name equals to "any_text_that_is_not_a_product_name"

Apply 'test' coupon to a frontend cart with a shipping amount.

Getting a coupon code is invalid. Hence, confirming this issue.

Please refer the attached screenshots.

Note : In 2.4.7 the option SKU under "product attribute combination" is not present. We are not able to see the option.

Please refer the screenshot.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-11876 is successfully created for this GitHub issue.

[m2-assistant]

✅ Confirmed by @engcom-Dash. Thank you for verifying the issue.
Issue Available: @engcom-Dash, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

[github-jira-sync-bot]

❌ You don't have permission to export this issue.

[glo17720]

@magento give me 2.4-develop instance

[magento-deployment-service]

Hi @glo17720. Thank you for your request. I'm working on Magento instance for you.

[magento-deployment-service]

Hi @glo17720, here is your Magento Instance: https://93af9f9cd29e6a619d3f129b984079ca.instances-prod.magento-community.engineering
Admin access: https://93af9f9cd29e6a619d3f129b984079ca.instances-prod.magento-community.engineering/admin_4061
Login: 73541fa4
Password: ee5e9bfcda9b