[Issue] Typecast incrementId variables always to a string

[m2-assistant]

This issue is automatically created based on existing pull request: #39452: Typecast incrementId variables always to a string

---

Description (*)

Ensure our calls to the sales_order table for the increment_id field are called with a string type and not an int type. When a module passed through an int variable, a full table scan occurs since the increment_id index can not be utilized.

Manual testing scenarios (*)

Create a small module and call the loadByIncrementId with an integer and see that this query is not hitting any index without this change.

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @igorwulff,

Thanks for the report and collaboration!

We investigated the issue in the latest 2.4-develop branch and the issue has been reproducible for us. Hence we are confirming the issue.

Just so you know, we are also attaching the module, which helps us in issue reproduction.

Magz.zip

Thanks for the contribution!