Reorder with a deleted parent configurable product

[dmanners]

Preconditions and environment

• Magento version - 2.4.7-p3
• Create a configurable product and place an order with a customer for this product
• After placing the order delete the product from the Magneto system

Steps to reproduce

1. Navigate the user that has placed this order in the admin,
2. Select the orders tab,
3. Find the desired order and click reorder,

Expected result

A message is shown to the user and the order is not placed.

Actual result

An uncaught exception cause the website to break.

Additional information

This happens because of the method \Magento\ConfigurableProductSales\Model\Order\Reorder\OrderedProductAvailabilityChecker::isAvailable.
Here the following will cause an uncaught exception.

$parentItem = $this->productRepository->getById($item->getParentItem()->getProductId());

To fix this we have created an around plugin that first performs a try-catch on the getById and when something is caught then we simply return false, otherwise we continue onto the main method.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @dmanners. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[m2-assistant]

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Bravo]

Hi @dmanners,

Thanks for your reporting and collaboration.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are not able to reproduce the issue.Kindly refer the screenshots.

A message is shown to the user This product is no longer available..

Kindly recheck the issue in Latest 2.4-develop instance and elaborate the steps to reproduce if the issue is still reproducible.

Thanks.

[dmanners]

Yeah I have confirmed it is still an issue on a locally checked out version of 2.4-develop when you delete not the ordered simple product but the top level configurable product as the code in https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProductSales/Model/Order/Reorder/OrderedProductAvailabilityChecker.php#L61 tries to look up the parent product but throws an exception that is never caught.

[engcom-Bravo]

Hi @dmanners,

Thanks for your update.

We have tried to reproduce the issue in Latest 2.4-develop instance and we are able to reproduce the issue.Kindly refer the screenshots.

An uncaught exception cause the website to break.

Hence Confirming the issue.

Thanks.