-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Closed
Labels
Area: CatalogComponent: CatalogIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: PR CreatedIndicates that Pull Request has been created to fix issueIndicates that Pull Request has been created to fix issueProgress: doneReported on 2.4.8Indicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch
Description
Preconditions and environment
- Magento version 2.4.8
- sample data. Or a category with at least 5 visible products
- Screen size more then 1024px
- default Luma theme
Steps to reproduce
- Open Category Page with products
- count columns in the first product row
Expected result
Actual result
Additional information
the commit 438f978 breaks all styles within .media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__l) {
like in
magento2/app/design/frontend/Magento/luma/Magento_Catalog/web/css/source/module/_listings.less
Lines 467 to 489 in 7b8064f
.media-width(@extremum, @break) when (@extremum = 'min') and (@break = @screen__l) { | |
.products-grid { | |
.product-item { | |
width: (100%/5); | |
} | |
} | |
.page-layout-1column { | |
.products-grid { | |
.product-item { | |
width: (100%/6); | |
} | |
} | |
} | |
.page-layout-3columns { | |
.products-grid { | |
.product-item { | |
width: (100%/4); | |
} | |
} | |
} |
All this styles https://github.com/search?q=repo%3Amagento%2Fmagento2+%22.media-width%28%40extremum%2C+%40break%29+when+%28%40extremum+%3D+%27min%27%29+and+%28%40break+%3D+%40screen__l%29+%7B%22&type=code are ignored on 2.4.8
Release note
Fix lost responsive styles for desktop
Triage and priority
- Severity: S0 - Affects critical data or functionality and leaves users without workaround.
- Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
- Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
- Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
- Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
nuzil and Vinai
Metadata
Metadata
Assignees
Labels
Area: CatalogComponent: CatalogIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedPriority: P2A defect with this priority could have functionality issues which are not to expectations.A defect with this priority could have functionality issues which are not to expectations.Progress: PR CreatedIndicates that Pull Request has been created to fix issueIndicates that Pull Request has been created to fix issueProgress: doneReported on 2.4.8Indicates original Magento version for the Issue report.Indicates original Magento version for the Issue report.Reproduced on 2.4.xThe issue has been reproduced on latest 2.4-develop branchThe issue has been reproduced on latest 2.4-develop branch