refreshAcl in Authentication plugin slows down all adminhtml requests

[ilnytskyi]

Preconditions and environment

• Magento version 2.4.7+
• Plugin Magento\Backend\App\Action\Plugin\Authentication enabled
• Have 17000+ rules in from in Magento\Authorization\Model\Acl\Loader\Rule::getRulesArray

Steps to reproduce

1. Perform any adminhtml requests.
2. See that Magento\Backend\App\Action\Plugin\Authentication::aroundDispatch calls the $this->_auth->getAuthStorage()->refreshAcl(); line https://github.com/magento/magento2/blame/2.4-develop/app/code/Magento/Backend/App/Action/Plugin/Authentication.php#L144
3. The call goes till the Magento\Authorization\Model\Acl\Loader\Rule::applyPermissionsAccordingToRules that adds about 200ms to total response time.

Expected result

1. Plugin Authentication::aroundDispatch does not slow down admin requests

Actual result

1. Plugin Authentication::aroundDispatch slows down admin requests

Additional information

Unfortunately it's unclear why this plugin is needed or why it triggers refreshAcl via $this->_auth->getAuthStorage()->refreshAcl();
The code added many years ago probably just as migration from Magento 1.

Release note

Fixed 200ms performance degradation in adminhtml area caused by Magento\Backend\App\Action\Plugin\Authentication::aroundDispatch plugin.

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @ilnytskyi. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[MagePsycho]

Can this be safely removed?

[m2-assistant]

Hi @engcom-Hotel. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
• 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
• 4. Verify that the issue is reproducible on 2.4-develop branch
  Details

  - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
• 5. Add label Issue: Confirmed once verification is complete.
• 6. Make sure that automatic system confirms that report has been added to the backlog.

[engcom-Hotel]

Hello @ilnytskyi,

Thanks for the report and collaboration!

We have tried to reproduce this issue in the latest 2.4-develop branch and php-spz profiler. We have profiled product listing page, which shows refreshAcl call 1 time. Please refer to the below screenshot for the reference:

Please let us know if we have missed anthing.

Thanks

[ilnytskyi]

@engcom-Hotel

Please profile adminhtml area, e.g. main dashboard page.
Preconditions: 17K rules.
It can be achieved via many admin users along with many roles have different ACL rights.

[engcom-Hotel]

Hello @ilnytskyi,

We have almost 19k rules now in the authorization_rule table:

We have also assigned some of the roles to Admin users, but still the issue is not reproducible for us:

Can you please try to reproduce this issue in the latest development branch i.e. 2.4-develop and let us know if it is reproducible for you?

Thanks