[Issue] Legacy stock status not updated after source items save

[darektw]

Preconditions and environment

Magento version : 2.4.8-p2 CE
PHP 8.3
mysql: 8.0.42
elasticsearch: 8.11

Issue discovered running integration tests, after upgrade from Magento 2.4.7

Steps to reproduce

1. Create simple product with stock data ['use_config_manage_stock' => 1, 'qty' => 0, 'is_qty_decimal' => 0, 'is_in_stock' => 0]
2. Update stock item

        /** \Magento\InventoryApi\Api\Data\SourceItemInterfaceFactory */
        $sourceItem = $this->sourceItemInterfaceFactory->create(['data' => [
            'sku' => '[sku]',
            'source_code' => 'default',
            'quantity' => 10,
            'status' => 1
        ]]);

        /** \Magento\Inventory\Model\SourceItem\Command\SourceItemsSave */
        $this->sourceItemsSave->execute([$sourceItem]);

3. check $product->isSalable()

Expected result

Product should be salable after source item update.

Actual result

Legacy stock status is not updated, which causes the problem with product availability.

Additional information

In Magento 2.4.8 the \Magento\InventoryCatalog\Model\SourceItemsSaveSynchronization\SetDataToLegacyCatalogInventory has been rewritten.

https://github.com/magento/inventory/blob/9659ed95f844e1a3fa55d81d179ed3631f91168d/InventoryCatalog/Model/SourceItemsSaveSynchronization/SetDataToLegacyCatalogInventory.php

magento/inventory@9659ed9#diff-bae52abf5559f41d7f3464d6171bb3ccf703b610d977014b4626098eb3643a05

In the class \Magento\InventoryCatalog\Model\UpdateDefaultStock:78 $statusAfter is false which prevents legacy stock update.

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @darektw. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[ijozwiak]

Hello, I believe my message finds you well.

I have the same issue described above and it also related the below reference

\Magento\InventoryCatalog\Model\UpdateDefaultStock:78 $statusAfter

It looks when a source item is saved status is not updated correctly in the cataloginventory_stock_status table.

Here: vendor/magento/module-inventory-catalog/Model/SourceItemsSaveSynchronization/SetDataToLegacyCatalogInventory.php:72 only the cataloginventory_stock_item table is updated.

Next Magento gets $affectedSkus here: vendor/magento/module-inventory-catalog/Model/SourceItemsSaveSynchronization/SetDataToLegacyCatalogInventory.php:78

but the processed sku is not returned because of \Magento\InventoryIndexer\Model\ResourceModel\GetStockItemData::execute works over a different table

The below patch is our temporary solution for this issue:

m248-fix-legacy-stock-after-source-save.patch

[engcom-Hotel]

Hello @darektw,

Thank you for the report and collaboration!

We have tried to reproduce this issue in the latest development branch i.e. 2.4-develop but it seems the issue is not reproducible for us.

We have prepared a custom module to reproduce the issue as below:

Issue40212.zip

After updating the simple product as mentioned above, for us the simple product is showing as salable. May be the issue is already addressed in some other scope.

Please let us know if we missed anything.

[darektw]

Hi @engcom-Hotel

The difference is with using frontend app state to update stockItem and these classes

        \Magento\Inventory\Model\SourceItem\Command\SourceItemsSave $sourceItemsSave,
        \Magento\InventoryApi\Api\Data\SourceItemInterfaceFactory $sourceItemInterfaceFactory,

Please check the updated module

Magz.zip