Update category issue

[krisdass]

I have created a new category and its not visible in navigation menu as of now.
I am adding products to it via code and its working.

Now i am editing the category to show in navigation menu, it thorws error as
"URL key for specified store already exists".

I tried to

• Unassign products, throws same error
• Changed URL, left blank or changed value of URL

Please let me know.

[maksek]

Hi @krisdass, what you mean by "let me know"? The error means you have similar category with the same URL key. And you trying to do another one. We don't know how you added products via code, and if it was correct.
Please provide exact steps to reproduce with examples and issue you are experience, then we will be able to try reproduce. At the current state the issue is not possible to confirm.

[krisdass]

Hi @maksek, The code for adding product programmatically is working fine.
But the issue noted was, After adding product when you are trying to update the category I am getting the error as "URL key for specified store already exists".

There is no duplication of URL. Even this error occurs when you edit product as well.

If you select any store from Store View dropdown, there is no error !

I am using Magento 2.0.4 version.

FYI : I am using following code to create products programmatically,

$product = $this->_objectManager->create('\Magento\Catalog\Model\Product');

// Set product's attribute values
$product->setStoreId($this->_helper->getStoreDetails()->getId()); // Set store id for the product
$product->setSku('prefix_'.$uniqId); // Set your sku 
$product->setName('Test Product'); // Name of Product
$product->setAttributeSetId($attributeSetId); // Attribute set id
$product->setStatus(0); // Status on product enabled/ disabled 1/0
$product->setWeight(0); // Weight of product
$product->setVisibility(4); // Visibilty of product (catalog / search / catalog, search / Not visible individually)
$product->setTaxClassId(0); // Tax class id
$product->setTypeId('simple'); // Type of product (simple/virtual/downloadable/configurable)
$product->setPrice(0); // Price of product
$product->setCategoryIds([3,5]); // Category ids
$product->setStockData(array(
    'use_config_manage_stock'   => 0,
    'manage_stock'          => 1,
    'is_in_stock'               => 1,
    'qty'                       => 1 // All products to have min stock for Product listing page
)); // stock datas
$product->setUrlKey($urlKey); // Dynamic Url key
$product->setWebsiteIds(array(1)); // Product under websites                            

// Adding Image to product
$product->addImageToMediaGallery($hasUploadedFile, array('image', 'small_image', 'thumbnail'), false, false);
$product->save();

Steps to Reproduce :

1. Create a category
2. Assign some product
3. Go to some other pages in admin and come back to categories page, select your category and then try to update any detail of the category.

[gamort]

I've run into a similar issue with magento 2.0.7 [and a number of prior versions].

Attempting to change a category url key throws a duplicate url error.

By turning on database query logging, I tracked down the query that through the error and discovered the issue was with product url's not category url's. When the category url key is updated it looks like:
url_rewrite is updated with the new category url[successful]
magento then builds an array of all the products in the category and what their new url paths should be[ie new category url/product-key

For some reason for every product request-path the array contains TWO copies of each new path per store. This means the attempt to update the table fails due to the duplicate url's trying to be set. The transaction is then rolled back and I'm left with a url_rewrite table that looks correct and should have no problems[because the problem was in the new urls being set, not the old ones!]

As a complete hack I changed Magento\UrlRewrite\Model\Storage\DbStorage on line 94:

magento2/app/code/Magento/UrlRewrite/Model/Storage/DbStorage.php

Line 94 in 6ea7d2d

foreach ($urls as $url) {

Replace the foreach loop with the following:
foreach ($urls as $url) {
$urlArray = $url->toArray();
$urlPath = $urlArray['request_path'];
$storeId = $urlArray['store_id'];
$dataKey = $storeId.'..'.$urlPath;
$data[$dataKey] = $urlArray;
}

This de-dupes the list of urls[specifically the list of urls for each store].

A better hack would be to subclass DbStorage and use dependency injection to use the subclass.

Obviously the REAL fix is to backtrack the code to figure out how/why these duplicates are being created. My guess would be whatever query is used to build this list either needs a DISTINCT added or to convert some of the filters from "OR" clauses to "AND" clauses.

With site launch one week away, I'm using the hack for now and as time permits will create a real fix and submit a pull request.

[krisdass]

Thank you @gamort . I will check your solution

[LoganGS]

I installed Magento via composer, so my core modules are in the "/vendor" directory.

I tracked down where the info was being inserted in the database. First breadcrumb was in this file:

vendor/magento/module-catalog-import-export/Model/Import/Product.php

At the bottom of the method _saveProducts(), we are calling _saveProductAttributes(), passing through the attributes (including the url_key). The _saveProductAttributes() method is calling the insertOnDuplicate() method from the Magento\Framework\DB\Adapter\Pdo\Mysql class:

vendor/magento/framework/DB/Adapter/Pdo/Mysql.php

An insert query is built towards the bottom of the insertOnDuplicate() method, defaulting to just updating the attribute value in the case there is a duplicate key.

I haven't yet found where the infamous exception / error message is being pulled in relative to this. I just see calls to the translator function containing the message here:

vendor/module-url-rewrite/Model/Storage/AbstractStorage.php
vendor/module-url-rewrite/Model/Storage/DbStorage.php

In my case, I was seeing the error while trying to import products (via System > Data Transfer > Import).

[afoucret]

I was able to reproduce this one while I was testing 2.1.0-rc2.

It seems the error handling is wrong into Magento\UrlRewrite\Model\Storage\AbstractStorage::replace

    public function replace(array $urls)
    {
        if (!$urls) {
            return;
        }

        try {
            $this->doReplace($urls);
        } catch (\Magento\Framework\Exception\AlreadyExistsException $e) {
            throw new \Magento\Framework\Exception\AlreadyExistsException(
                __('URL key for specified store already exists.')
            );
        }
    }

The code here is catching an exception raised by the doReplace method and raising the same type of exception (with the same message).

Everything goes find again when I replace the the code bellow by :

/**
    public function replace(array $urls)
    {
        if (!$urls) {
            return;
        }

        $this->doReplace($urls);
    }

The doReplace method (implemented into the DBStorage) does the job nicely and the duplicated URL rewrite feature is still operational (tested on my dataset).

I will provide a PR for this one.