Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect return value from Product Attribute Repository #4803

Closed
samtay opened this issue May 31, 2016 · 8 comments

Comments

@samtay
Copy link

commented May 31, 2016

To adhere to Magento\Catalog\Api\ProductAttributeRepositoryInterface (extends Magento\Framework\Api\MetadataServiceInterface), the

Magento\Catalog\Model\Product\Attribute\Repository::getCustomAttributesMetadata

implementation should return Magento\Framework\Api\MetadataObjectInterface[], however it instead returns Magento\Catalog\Api\Data\ProductAttributeInterface[].

The ProductAttributeInterface does declare the two methods declared in MetadataObjectInterface , however they are not related by PHP extend.

@MomotenkoNatalia MomotenkoNatalia added the MX label Jun 1, 2016

@andimov

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2016

@samtay, to allow us research the issue, please, provide the used version and description according to the template.

@andimov andimov self-assigned this Jun 23, 2016

@samtay

This comment has been minimized.

Copy link
Author

commented Jun 24, 2016

The issue exists on all versions, on CE develop branch. The description is in the initial comment. I don't see what more information you need? This isn't a huge deal, I'm just letting you know there is a disconnect in the hierarchy of the interfaces. The documentation is incorrect -- which the framework can be very finicky about sometimes when generating code or parsing objects in the webapi. Something for you to be aware of.

@vkublytskyi

This comment has been minimized.

Copy link

commented Jul 15, 2016

@samtay, thank you for reporting this issue. To fix this issue we will add declaration that Magento\Eav\Api\Data\AttributeInterface extends Magento\Framework\Api\MetadataObjectInterface.
Internal ticket MAGETWO-55438.

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Nov 23, 2017

@samtay, thank you for your report.
We've created internal ticket(s) MAGETWO-55438 to track progress on the issue.

@julianvdrielen

This comment has been minimized.

Copy link
Contributor

commented Jun 2, 2018

I will be working on this issue

@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

Hi @samtay. Thank you for your report.
The issue has been fixed in #15691 by @cream-julian in 2.2-develop branch
Related commit(s):

The fix will be available with the upcoming 2.2.7 release.

magento-engcom-team added a commit that referenced this issue Aug 8, 2018
ENGCOM-2642: Fix #4803: Incorrect return value from Product Attribute…
… Repository #15691

 - Merge Pull Request #15691 from cream-julian/magento2:2.2-develop-forward-issue-4803
 - Merged commits:
   1. 4c1989e
   2. 215be5a
   3. 2639d0e
   4. 43dd85e
magento-engcom-team pushed a commit that referenced this issue Aug 8, 2018
@sidolov

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2018

Hi @samtay. Thank you for your report.
The issue has been fixed in #15688 by @cream-julian in 2.1-develop branch
Related commit(s):

The fix will be available with the upcoming 2.1.16 release.

magento-engcom-team added a commit that referenced this issue Aug 8, 2018
ENGCOM-2707: [Backport] Fix #4803: Incorrect return value from Produc…
…t Attribute Repository #15688

 - Merge Pull Request #15688 from cream-julian/magento2:2.1-develop-issue-4803
 - Merged commits:
   1. d409248
   2. 90f37dc
   3. b064cd7
magento-engcom-team pushed a commit that referenced this issue Aug 8, 2018
@magento-engcom-team

This comment has been minimized.

Copy link
Contributor

commented Aug 10, 2018

Hi @samtay. Thank you for your report.
The issue has been fixed in #15723 by @cream-julian in 2.3-develop branch
Related commit(s):

The fix will be available with the upcoming 2.3.0 release.

magento-engcom-team added a commit that referenced this issue Aug 10, 2018
ENGCOM-2708: [Forwardport] Fix #4803: Incorrect return value from Pro…
…duct Attribute Repository #15723

 - Merge Pull Request #15723 from cream-julian/magento2:2.3-develop-forward-issue-4803
 - Merged commits:
   1. 19ca090
   2. 4e51e9c
   3. a8dc518
   4. 40f046e
magento-engcom-team pushed a commit that referenced this issue Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.