Regression: Cart Price Rules: Empty "From" and "To" values are replaced with todays date

[heldchen]

In Magento 1 you could have Cart Sales Rules with no start and/or end date, i.e. codes with unlimited validity. In Magento 2, saving a rule with an empty start and/or end date will automatically fill the current date as value.

Preconditions

1. Magento 2.1.0

Steps to reproduce

1. Create new "Cart Price Rule"
2. Do not fill a value in "From" and "To"
3. Save & continue editing

Expected result

1. "From" and "To" fields should be empty
2. The rule should be saved without date and be always valid

Actual result

1. Todays date is filled into "From" and "To"
2. The rule is date restricted

[heldchen]

the post fields from_date and to_date are filtered in \Magento\SalesRule\Controller\Adminhtml\Promo\Quote\Save::execute():

                $data = $this->getRequest()->getPostValue();
                $inputFilter = new \Zend_Filter_Input(
                    ['from_date' => $this->_dateFilter, 'to_date' => $this->_dateFilter],
                    [],
                    $data
                );
                $data = $inputFilter->getUnescaped();

unfortunately \Magento\Framework\Stdlib\DateTime\Filter\Date does not handle empty strings:

    public function filter($value)
    {
        try {
            $value = new \DateTime($value);
            return $value->format('Y-m-d');
        } catch (\Exception $e) {
            throw new \Exception("Invalid input date format '$value'");
        }
    }

initializing a \DateTime object with an empty string will automatically use todays date.

[heldchen]

here's a quick (and dirty) workaround: in Magento\SalesRule\Controller\Adminhtml\Promo\Quote\Save::execute() replace

                $data = $this->getRequest()->getPostValue();
                $inputFilter = new \Zend_Filter_Input(
                    ['from_date' => $this->_dateFilter, 'to_date' => $this->_dateFilter],
                    [],
                    $data
                );
                $data = $inputFilter->getUnescaped();
                $id = $this->getRequest()->getParam('rule_id');

with

                $data = $this->getRequest()->getPostValue();
                $inputFilter = new \Zend_Filter_Input(
                    ['from_date' => $this->_dateFilter, 'to_date' => $this->_dateFilter],
                    [],
                    $data
                );
                if (array_key_exists('from_date', $data)) {
                    $data['from_date'] = trim($data['from_date']) ? $inputFilter->getUnescaped('from_date') : '';
                }
                if (array_key_exists('to_date', $data)) {
                    $data['to_date'] = trim($data['to_date']) ? $inputFilter->getUnescaped('to_date') : '';
                }
                $id = $this->getRequest()->getParam('rule_id');

[heldchen]

still present in 2.1.1

[sevos1984]

Can't reproduce on clean install of 2.1.1. Have you upgraded from previous versions?

[heldchen]

yes, 2.0.4 was our starting point. our 2.1.1 store still shows this behaviour and the above mentioned patch fixes the problem. will retry on a clean 2.1.1 and report back.

[heldchen]

sorry for the delay, the post shop launches prevented me from retesting. will be done ASAP.

[heldchen]

it seems that your team was able to reproduce it after all: #6762 - MAGETWO-59047