Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magento 2.1.x No support for PHP7.1 #7663

Closed
BigL opened this issue Dec 2, 2016 · 7 comments
Closed

Magento 2.1.x No support for PHP7.1 #7663

BigL opened this issue Dec 2, 2016 · 7 comments

Comments

@BigL
Copy link

BigL commented Dec 2, 2016

Preconditions

  1. PHP 7.1.0RC6 (cli) ( NTS )
    2 . Magento CLI version 2.1.2

Steps to reproduce

  1. ./bin/magento setup:upgrade
  2. ./bin/magento setup:di:compile

Expected result

  1. successful compiled DI

Actual result

1.Repositories code generation... 1/7 [====>-----------------------] 14% 1 sec 42.0 MiBPHP Fatal error: Cannot use 'Void' as class name as it is reserved in /data/vendor/magento/module-sales/Controller/Adminhtml/Order/Creditmemo/Void.php on line 10

This doesn't happen on PHP7.0

@maksek
Copy link
Contributor

maksek commented Dec 2, 2016

We are not supporting PHP 7.1 yet.

@csdougliss
Copy link
Contributor

@maksek When? :)

@ghost
Copy link

ghost commented Dec 20, 2016

In order to compile I changed it to Voided. I know it broke something but I havent found it yet...
Cannot use 'Void' as class name as it is reserved in app/code/Magento/Sales/Controller/Adminhtml/Order/Creditmemo/Void.php on line 10
Cannot use 'Void' as class name as it is reserved in app/code/Magento/Sales/Controller/Adminhtml/Order/Invoice/Void.php on line 9

@dmitrii-fediuk
Copy link

dmitrii-fediuk commented Dec 30, 2016

My fix: https://example.com/t/2433
None of the Magento 2 functionality is broken.

@QWp6t
Copy link

QWp6t commented Dec 30, 2016

PHP 5.6 officially no longer under active support.

Might be time to revisit this issue.

@orlangur
Copy link
Contributor

@dmitry-fedyuk, your fix is lame.

You can get an idea for proper fix from https://github.com/magento/magento2/blob/develop/app/code/Magento/Catalog/Controller/Adminhtml/Product/NewAction.php#L13 ;)

@davidalger
Copy link
Member

This issue has been addressed via PR #8609. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants