New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party payment gateways not visible in adminhtml anymore on 2.1.3 #7891

Closed
danteay opened this Issue Dec 19, 2016 · 7 comments

Comments

@danteay

danteay commented Dec 19, 2016

Preconditions

  1. Fresh install of Magento 2.1.3 with tar.gz package
  2. 3rd Party payment gateway compatible Magento 2.1.2
  3. PHP 7.0.10

Steps to reproduce

  1. Put 3rd Party gateway code inside of app/code folder (for example https://github.com/compropago/plugin-magento-2)
  2. run bin/magento setup:upgrade
  3. run bin/magento setup:di:compile
  4. run bin/magento cache:flush
  5. run bin/magento indexer:reindex

Expected result

  1. Show gateway config in Stores -> Configuration -> Sales -> Payment Methods

Actual result

  1. dont display the config in admin panel
    captura de pantalla 2016-12-19 a la s 16 41 47

In the compile and upgrade comand it works, an the observers works to, but the config dosn't show in the panel in any moment

@petterkj

This comment has been minimized.

Show comment
Hide comment
@petterkj

petterkj Dec 20, 2016

Contributor

I would say wtf.. A really critical bug. Can reproduce. We use https://github.com/DIBS-Payment-Services/magento2-dibs-flexwin but it doesn't show anymore.

Contributor

petterkj commented Dec 20, 2016

I would say wtf.. A really critical bug. Can reproduce. We use https://github.com/DIBS-Payment-Services/magento2-dibs-flexwin but it doesn't show anymore.

@hostep

This comment has been minimized.

Show comment
Hide comment
@hostep

hostep Dec 20, 2016

Collaborator

Yesterday I read this blogpost: https://www.maxpronko.com/blog/magento-2-1-3-payment-changes-overview-and-recommendations

@mcspronko mentions the payment gateways have to add the <can_checkout>1</can_checkout> xml node to their config.xml file. I'm not entirely sure if this has consequences for not displaying the payment methods in the adminhtml itself though?

The strange thing is that Magento introduced this in a bugfix release, which shouldn't contain backwards incompatible changes, but oh well, it happens all the time unfortunately...
Also this change hasn't been documented in the neither the release notes or in the backwards incompatible changes page, @xcomSteveJohnson ?

Collaborator

hostep commented Dec 20, 2016

Yesterday I read this blogpost: https://www.maxpronko.com/blog/magento-2-1-3-payment-changes-overview-and-recommendations

@mcspronko mentions the payment gateways have to add the <can_checkout>1</can_checkout> xml node to their config.xml file. I'm not entirely sure if this has consequences for not displaying the payment methods in the adminhtml itself though?

The strange thing is that Magento introduced this in a bugfix release, which shouldn't contain backwards incompatible changes, but oh well, it happens all the time unfortunately...
Also this change hasn't been documented in the neither the release notes or in the backwards incompatible changes page, @xcomSteveJohnson ?

@petterkj

This comment has been minimized.

Show comment
Hide comment
@petterkj

petterkj Dec 20, 2016

Contributor

I think here is a hint to fix this. sortOrder seems to conflict this. See DIBS-Payment-Services/magento2-dibs-flexwin#15 (comment) . Fix would be to not make sortOrder decide whenever to ignore other payment methods -if thats the issue here.

Contributor

petterkj commented Dec 20, 2016

I think here is a hint to fix this. sortOrder seems to conflict this. See DIBS-Payment-Services/magento2-dibs-flexwin#15 (comment) . Fix would be to not make sortOrder decide whenever to ignore other payment methods -if thats the issue here.

maxwhite added a commit to DIBS-Payment-Services/magento2-dibs-flexwin that referenced this issue Dec 22, 2016

@snez

This comment has been minimized.

Show comment
Hide comment
@snez

snez Dec 24, 2016

I confirm that as @petterkj mentioned, adjusting the sortOrder field will fix this. For users of the Stripe Payments & Subscriptions module, the solution is now documented here.

snez commented Dec 24, 2016

I confirm that as @petterkj mentioned, adjusting the sortOrder field will fix this. For users of the Stripe Payments & Subscriptions module, the solution is now documented here.

@vkublytskyi

This comment has been minimized.

Show comment
Hide comment
@vkublytskyi

vkublytskyi Dec 26, 2016

Contributor

@danteay, thank you for reporting this issue. We confirmed it in 2.1.3 release and develop branch. Internal ticket MAGETWO-62667 is created to address this issue. We understand that such bug is critical and we will take measures to avoid such issues in future.

As reported by @petterkj and @snez, for now, third party payment method configuration would be displayed in admin panel only if group sortOrder specified in etc/adminhtml/system.xml file is greater than 4.

Contributor

vkublytskyi commented Dec 26, 2016

@danteay, thank you for reporting this issue. We confirmed it in 2.1.3 release and develop branch. Internal ticket MAGETWO-62667 is created to address this issue. We understand that such bug is critical and we will take measures to avoid such issues in future.

As reported by @petterkj and @snez, for now, third party payment method configuration would be displayed in admin panel only if group sortOrder specified in etc/adminhtml/system.xml file is greater than 4.

@vkublytskyi vkublytskyi self-assigned this Dec 26, 2016

@danteay

This comment has been minimized.

Show comment
Hide comment
@danteay

danteay Dec 26, 2016

Tank you @vkublytskyi I try this to fix this error, and I hope that this issue is resolved soon.

danteay commented Dec 26, 2016

Tank you @vkublytskyi I try this to fix this error, and I hope that this issue is resolved soon.

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

MAGETWO-62667: [GITHUB] 3rd party payment gateways not visible in adm…
…inhtml anymore on 2.1.3 #7891

 - refactoring: moved buggy code to separate class

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

MAGETWO-62667: [GITHUB] 3rd party payment gateways not visible in adm…
…inhtml anymore on 2.1.3 #7891

 - covered with green unit tests

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

MAGETWO-62667: [GITHUB] 3rd party payment gateways not visible in adm…
…inhtml anymore on 2.1.3 #7891

 - added test case for reported bug
 - fixed removal of configuration group if it ordered before special group

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

MAGETWO-62667: [GITHUB] 3rd party payment gateways not visible in adm…
…inhtml anymore on 2.1.3 #7891

 - added test for case when displayIn reference not to special group
 - fixed issue with reference to not special group in displayIn attribute

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

MAGETWO-62667: [GITHUB] 3rd party payment gateways not visible in adm…
…inhtml anymore on 2.1.3 #7891

 - added test for case when several payment methods from one group reference to different special groups
 - fixed implementation issue

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

MAGETWO-62667: [GITHUB] 3rd party payment gateways not visible in adm…
…inhtml anymore on 2.1.3 #7891

 - applying coding standards

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

MAGETWO-62667: [GITHUB] 3rd party payment gateways not visible in adm…
…inhtml anymore on 2.1.3 #7891

 - applying PSR2 code style

mmansoor-magento pushed a commit that referenced this issue Jan 11, 2017

@alena-marchenko

This comment has been minimized.

Show comment
Hide comment
@alena-marchenko

alena-marchenko Jan 12, 2017

Contributor

Hi @danteay,

Fix for MAGETWO-62667 is merged to develop branch, closing the issue.
Also, this fix will be available in Magento 2.1.4 release.
Thank you.

Contributor

alena-marchenko commented Jan 12, 2017

Hi @danteay,

Fix for MAGETWO-62667 is merged to develop branch, closing the issue.
Also, this fix will be available in Magento 2.1.4 release.
Thank you.

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - refactoring: moved buggy code to separate class

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - covererd with green unit tests

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - added test case for reported bug
 - fixed removal of configuration group if it ordered before special group

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - added test for case when displayIn reference not to special group
 - fixed issue with reference to not special group in displayIn attribute

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - added test for case when several payment methods from one group reference do different special groups
 - fixed implementation issue

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - added docblock

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - fixed failed unit test due to incorrect mock of section modifier

okorshenko pushed a commit that referenced this issue Feb 7, 2017

MAGETWO-62669: [Backport] [GITHUB] 3rd party payment gateways not vis…
…ible in adminhtml anymore on 2.1.3 #7891 - 2.1.4

 - fixed unit test namespace

boris-burgos added a commit to Codeko/magento2-redsys that referenced this issue May 4, 2017

refs #9765 Fix to workaround the MAGETWO-62667 issue in 2.1.3
magento/magento2#7891
Changed sortOrder of the system.xml section from 1 to 10

ibrahimlawal added a commit to PaystackHQ/paystack-magento2 that referenced this issue Jun 19, 2017

Set sortOrder to 400
This will ensure Magento 2.1.3 users will be able to see the payment method. REF: magento/magento2#7891

@magento-engcom-team magento-engcom-team moved this from TODO to Done in branch [2.1-develop] Sep 13, 2017

@magento-engcom-team magento-engcom-team moved this from TODO to Done in branch [2.3-develop] Sep 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment