Skip to content

getCacheTags for price issue #9877

@Styopchik

Description

@Styopchik

Preconditions

Problem on Magento 2.1.5.

Steps to reproduce

\Magento\Catalog\Block\Category\Plugin\PriceBoxTags::getTaxRateIds in line 104

Actual result

calls $rateRequest like this:
$rateRequest = $this->getTaxCalculation()->getRateRequest(
$billingAddress,
$shippingAddress,
$customerTaxClassId,
$this->scopeResolver->getScope()->getId(),
$this->customerSession->getCustomerId()
);

Expected Result

but the original method accepts $shippingAddress first

public function getRateRequest(
$shippingAddress = null,
$billingAddress = null,
$customerTaxClass = null,
$store = null,
$customerId = null
)

Metadata

Metadata

Assignees

Labels

Fixed in 2.2.xThe issue has been fixed in 2.2 release lineFixed in 2.3.xThe issue has been fixed in 2.3 release lineIssue: Clear DescriptionGate 2 Passed. Manual verification of the issue description passedIssue: ConfirmedGate 3 Passed. Manual verification of the issue completed. Issue is confirmedIssue: Format is validGate 1 Passed. Automatic verification of issue format passedIssue: Ready for WorkGate 4. Acknowledged. Issue is added to backlog and ready for development

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions