Skip to content

Conversation

EliasKotlyar
Copy link
Contributor

@EliasKotlyar EliasKotlyar commented Jun 22, 2017

Please refactor it! Do not merge directly!

Description

Its a dirty solution for the race condition of the translations.

Fixed Issues (if relevant)

#7363

Manual testing scenarios

Contribution checklist

  • [ X] Pull request has a meaningful description of its purpose
  • [X ] All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Jun 22, 2017
@okorshenko okorshenko added this to the June 2017 milestone Jun 22, 2017
@okorshenko
Copy link
Contributor

Hi @EliasKotlyar
Thank you for you pull request. Unfortunately we can not accept this PR as is (as you also noticed). Our frontend team is working right now on this. The solution should be ready soon. Closing this PR. Let's wait for 2.2 release. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants