Skip to content

Backport 1b55a64 to 2.1 - Fixes #6818 #10218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 13, 2017

Conversation

AntonEvers
Copy link
Contributor

@AntonEvers AntonEvers commented Jul 12, 2017

Please add this to the 2.1.8 release if it can be made in time.

Fixed Issues (if relevant)

  1. PageCache gives error "Uncaught TypeError: element.prop is not a function" when there is an iframe #6818: PageCache gives error "Uncaught TypeError: element.prop is not a function" when there is an iframe

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

Please add this to the 2.1.8 release if it can be made in time.
@hostep
Copy link
Contributor

hostep commented Jul 12, 2017

Not sure if this is enough to fix it, maybe these changes are also necessary:
#8005

I'm totally not sure about this, there are a lot of comments spreading across multiple issues and PR's discussing very similar problems. I just want to make sure the correct code is being backported :)

@okorshenko okorshenko changed the base branch from 2.1 to 2.1-develop July 12, 2017 15:03
@okorshenko okorshenko self-assigned this Jul 12, 2017
@okorshenko okorshenko added this to the July 2017 milestone Jul 12, 2017
Oskar Mothander and others added 7 commits July 13, 2017 10:15
@AntonEvers
Copy link
Contributor Author

@hostep I have added them, will test on my own machine now.

@AntonEvers
Copy link
Contributor Author

@hostep this works just as well indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants