Skip to content

Conversation

adrian-martinez-interactiv4
Copy link
Contributor

@adrian-martinez-interactiv4 adrian-martinez-interactiv4 commented Oct 11, 2017

Description

Backport of PR#11359

Backported cron:install and cron:remove commands.

Unable to manage (install/uninstall) cron via bin/magento cron:install / cron:remove with multiple installations against same crontab. Having two (or more) installations in different folders, it's not possible to create different crontab entries for both of them, because of the same prefix and suffix used for both of them (#~ MAGENTO START and #~ MAGENTO END)

Fixed Issues (if relevant)

No related issue found

Manual testing scenarios

  1. Install Magento 2 in two different folders.
  2. Run bin/magento cron:install on both of them
  3. The second one fails because the first one already installed a cron entry

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

…ultiple instances in the same crontab, based on installation directory
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 force-pushed the FR21#CRON-INSTALL-MULTIPLE-INSTANCES branch from f7fd068 to fdd1b9d Compare October 12, 2017 17:58
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 changed the title Backported cron:install and cron:remove commands, support to manage multiple instances in the same crontab, based on installation directory [Backport 2.1-develop] cron:install and cron:remove commands, support to manage multiple instances in the same crontab, based on installation directory Oct 13, 2017
@magento-team magento-team merged commit fdd1b9d into magento:2.1-develop Oct 19, 2017
magento-team pushed a commit that referenced this pull request Oct 19, 2017
…ort to manage multiple instances in the same crontab, based on installation directory #11361

 - fixed copyright
magento-team pushed a commit that referenced this pull request Oct 19, 2017
…ort to manage multiple instances in the same crontab, based on installation directory #11361
@adrian-martinez-interactiv4 adrian-martinez-interactiv4 deleted the FR21#CRON-INSTALL-MULTIPLE-INSTANCES branch October 19, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants