Skip to content

MAGETWO-81245: Handling all setProductsFilter items in array as arguments #11500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2017

Conversation

kirmorozov
Copy link
Member

Capture arguments after call_user_func_array and keep other map* methods working as they work now.

Description

Will pass products as arguments because of interface.

Fixed Issues (if relevant)

  1. StockItemCriteria::setProductsFilter doesn't work with array of ids #7678: StockItemCriteria::setProductsFilter doesn't work with array of ids

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@okorshenko okorshenko self-assigned this Oct 16, 2017
@okorshenko okorshenko added this to the October 2017 milestone Oct 16, 2017
@okorshenko okorshenko added Release Line: 2.2 2.2.x bug report Event: MMNY17 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Oct 16, 2017
@kirmorozov
Copy link
Member Author

Finally, after restating travis tests 2 times it passed.

magento-team pushed a commit that referenced this pull request Oct 19, 2017
@magento-team magento-team merged commit 03c6d20 into magento:2.2-develop Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Event: MMNY17 Progress: accept Release Line: 2.2 Reproduced on 2.1.x The issue has been reproduced on latest 2.1 release Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants